Use CMake variables for shared/static library suffixes #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
force-pushed
the
topic/timw/use-cmake-variables-for-library-name-suffixes
branch
from
af9cc63 to
1efc03b
Compare
timwoj
force-pushed
the
topic/timw/use-cmake-variables-for-library-name-suffixes
branch
from
1efc03b to
d38f51d
Compare
awelzel
approved these changes
Dec 11, 2024
awelzel
approved these changes
Dec 12, 2024
timwoj
force-pushed
the
topic/timw/use-cmake-variables-for-library-name-suffixes
branch
from
a8e4c49 to
d38f51d
Compare
timwoj
deleted the
topic/timw/use-cmake-variables-for-library-name-suffixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while adding Redis support to the storage framework branch. We can't hardcode
.so/.afor all platforms because on Windows it's.dll/.liband on macOS shared libraries are.dylib. Use CMake variables to make these checks platform-independent.