Fix linker errors with improper hooks files #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the analyzer was used for hooks, but this doesn't work if there are multiple modules and they have hooks. Or, if the name differs from the module which contains hooks.
evantypanski
force-pushed
the
topic/etyp/spicy-plugin-hooks-fix
branch
from
8f06197 to
c20e282
Compare
ckreibich
approved these changes
Mar 18, 2025
Member
|
Evan if a module is spread across multiple |
rsmmr
approved these changes
Mar 18, 2025
Member
Actually it does not allow that: one file per module only. |
Contributor
Author
|
They'll each get a unique ID even if they have identical names it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the analyzer was used for hooks, but this doesn't work if there are multiple modules and they have hooks. One hooks file is made for each module, so they should all be included.
For context, I encountered this with the Redis analyzer. The analyzer is named Redis, but hooks are in the RESP module, so it gave linker errors when building.