Skip to content

Do not leak dependencies of plugins #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timwoj merged 1 commit into from
May 19, 2025
Merged

Do not leak dependencies of plugins #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ZeekPluginDynamic.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function (zeek_add_dynamic_plugin ns name)

# Add user-defined extra dependencies.
if (FN_ARGS_DEPENDENCIES)
target_link_libraries(${target_name} PUBLIC ${FN_ARGS_DEPENDENCIES})
target_link_libraries(${target_name} PRIVATE ${FN_ARGS_DEPENDENCIES})
endif ()

# Add the sources for the plugin.
Expand Down
2 changes: 1 addition & 1 deletion ZeekPluginStatic.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function (zeek_add_static_plugin ns name)

# Add extra dependencies.
if (FN_ARGS_DEPENDENCIES)
target_link_libraries(${target_name} PUBLIC ${FN_ARGS_DEPENDENCIES})
target_link_libraries(${target_name} PRIVATE ${FN_ARGS_DEPENDENCIES})
endif ()

# Add the sources for the plugin.
Expand Down
Loading