Skip to content

Remove FindClangTidy.cmake, don't lint built-in plugins #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timwoj merged 2 commits into from
May 23, 2025
Merged

Remove FindClangTidy.cmake, don't lint built-in plugins #135

timwoj merged 2 commits into from
May 23, 2025

Conversation

@timwoj
Copy link
Member

@timwoj timwoj commented May 22, 2025

This does two things:

  • Removes the now-obsolete FindClangTidy.cmake, which isn't needed anymore after all of the changes with how linters are setup in CMake recently.
  • Removes source files from external plugins being built into Zeek from being linted. This means that files from things like af-packet and zeekjs won't be linted by Zeek's build process anymore.

timwoj added 2 commits May 22, 2025 16:02
@timwoj
Remove FindClangTidy.cmake
e324258 
After all of the recent changes to how we setup clang-tidy in CMake,
this file isn't needed anymore.
@timwoj
Don't lint files from external plugins being built into Zeek
c8dfb02
@timwoj timwoj force-pushed the topic/timw/remove-findclangtidy branch from 75acf5e to c8dfb02 Compare May 22, 2025 23:02
@timwoj timwoj mentioned this pull request May 22, 2025
Merged
@timwoj timwoj merged commit d605f50 into master May 23, 2025
1 check passed
@timwoj timwoj deleted the topic/timw/remove-findclangtidy branch May 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awelzel awelzel awelzel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timwoj @awelzel