Do not tweak test targets from Spicy #136
Conversation
auxil/spicy or more correctly its dependency justrx emitted its test targets into the build and we reconfigured them. Since we will not build these targets going forward and they will actually be unknown remove their configuration.
| hilti-rt-objects | ||
| hiltic | ||
| jrx-objects | ||
| retest |
There was a problem hiding this comment.
Fly-by food-for-thought: Would we have a good place in the zeek repos to place this? Meaning the whole file.
There was a problem hiding this comment.
Using this in the for loop below could work as well in case Zeek would ever set SPICY_ENABLE_TESTS to on, but might hide problems as well (?)
if ( TARGET ... )
There was a problem hiding this comment.
All this file does is tweak the build of Spicy targets when it is built as part of Zeek, so there is zero potential for reuse. I'd just put this on top of the line doing add_subdirectory(auxil/spicy) in zeek/zeek 🤷.
Even when building with Spicy tests this should still work. One could see more errors, but the build would finish (unless building with -Werror, but okay). I don't think we need to accommodate for that scenario here.
There was a problem hiding this comment.
Unrelated, if the intention for this repo was "CMake functionality reusable across the ecosystem", it has accumulated a lot of stuff which should just be in zeek/zeek.
There was a problem hiding this comment.
I'd just put this on top of the line doing add_subdirectory(auxil/spicy) in zeek/zeek
👍
Unrelated, if the intention for this repo was "CMake functionality reusable across the ecosystem", it has accumulated a lot of stuff which should just be in zeek/zeek.
Yeah, that's the angle I was looking at this change right now, too.
auxil/spicy or more correctly its dependency justrx emitted its test targets into the build and we reconfigured them. Since we will not build these targets going forward and they will actually be unknown remove their configuration.