Add external directories included by plugins as system directories #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
reviewed
Jun 11, 2025
ZeekPluginStatic.cmake
Outdated
| if (FN_ARGS_INCLUDE_DIRS) | ||
| target_include_directories(${target_name} PRIVATE ${FN_ARGS_INCLUDE_DIRS}) | ||
| foreach (_include_dir ${FN_ARGS_INCLUDE_DIRS}) | ||
| cmake_path(IS_PREFIX PROJECT_SOURCE_DIR "${_include_dir}" _is_project_prefixed) |
Contributor
There was a problem hiding this comment.
Is this for not doing it explicitly like done here?
What are include dirs causing issues?
Member
Author
There was a problem hiding this comment.
The difference is that adding the directories as system dirs allows me to ignore them all at once, instead of individually having to SKIP_LINTING on each file we might include from somewhere. For example, I can add /opt/homebrew/include on macOS and catch a lot of external files that we'd include.
As for what dirs were causing issues, I ran into openssl, krb5, hiredis, and a few others. Yes, I could extend the regex in .clang-tidy to include these (and I did at first), but this method makes more sense to me.
timwoj
force-pushed
the
topic/timw/clang-tidy-fixes
branch
from
8ca1061 to
3897377
Compare
awelzel
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the include style for directories outside of the current project tree to use
-isysteminstead of-I. This allows clang-tidy to ignore those files with theSystemHeaders: falseconfiguration option. I only made this change for static plugins, since we probably won't be running clang-tidy with dynamic plugins.