Skip to content

Conversation

@bbannier
Copy link
Member

@bbannier bbannier commented Jul 4, 2025

No description provided.

@bbannier bbannier self-assigned this Jul 4, 2025
@bbannier bbannier marked this pull request as ready for review July 4, 2025 19:28
@bbannier bbannier requested a review from rsmmr July 4, 2025 19:28
Copy link
Member

@rsmmr rsmmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably forgetting something: what preprocessing are we're doing with zeek_rt.hlt?

@bbannier bbannier changed the title Adjust building of Spicy analyzers agains preprocessed zeek_rt.hlt Adjust building of Spicy analyzers against preprocessed zeek_rt.hlt Jul 7, 2025
@bbannier
Copy link
Member Author

bbannier commented Jul 7, 2025

I'm probably forgetting something: what preprocessing are we're doing with zeek_rt.hlt?

This is needed over in https://github.com/zeek/zeek/pull/4632/files where I preprocess zeek_rt.hlt with CMake to generate a linker scope type which works across versions (HILTI itself does not support preprocessor macros).

@rsmmr
Copy link
Member

rsmmr commented Jul 7, 2025

This is needed over in https://github.com/zeek/zeek/pull/4632/files where I preprocess zeek_rt.hlt with CMake to generate a linker scope type which works across versions (HILTI itself does not support preprocessor macros).

Ah, reviewed in the wrong order. Will look there.

@bbannier
Copy link
Member Author

bbannier commented Jul 8, 2025

This is not needed anymore since I adjusted zeek/zeek#4632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants