Add ability to seal enum classes in Dart #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @jerel. Can you rebase for the CI? |
jerel
force-pushed
the
dart-sealed-classes
branch
from
f2bf7d5 to
b595a33
Compare
jerel
force-pushed
the
dart-sealed-classes
branch
from
e76e2df to
638a451
Compare
Contributor
Author
|
@ma2bd I've rebased and CI checks are passing. |
ma2bd
reviewed
Dec 8, 2025
| pub c_style: bool, | ||
| // Generate sealed class if `true` or abstract class if `false` | ||
| pub sealed: bool, | ||
| // If `sealed_enums` is true then the listed names will be abstract, |
Contributor
There was a problem hiding this comment.
Do you mean "If sealed is true" etc?
| self | ||
| } | ||
|
|
||
| /// Generate abstract or sealed classes for data enums based on `with_sealed_enums` |
Contributor
There was a problem hiding this comment.
nit: typo: extra space "enums based"
| self.output_enum_container(name, variants)?; | ||
| } else if (self.generator.config.enums.sealed | ||
| && !self.generator.config.enums.output_type.contains_key(name)) | ||
| || self.generator.config.enums.output_type.get(name) == Some(&"sealed") |
Contributor
There was a problem hiding this comment.
Looks like we're not using output_type as much when the value is not "enum" or "sealed", right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a project we have a need to generate sealed classes in Dart but fall back to abstract classes in some cases. This PR adds the ability to configure enum generation by creating an EnumConfig struct and optionally specifying a map of types which should use the specified behavior.
I don't know if this fits into your vision for this project but I figured I'd open this PR and see what you thought as it would be nice to keep parity with this main project.
Test Plan
The default is to generate all code exactly as it has been in the past. The new sealed behavior has to be opted in to.