Fix application process exit after launching new approach#2
Fix application process exit after launching new approach#2
Conversation
quangnt
force-pushed
the
fix-application-process-exit-after-launching
branch
from
eecb54b to
74bde8f
Compare
|
@zelonght Address comments. Change approach to Find child process bases on parent id and parent name. Can you review it? |
quangnt
force-pushed
the
fix-application-process-exit-after-launching
branch
from
74bde8f to
4953d48
Compare
CHANGELOG.md
Outdated
| ## v2.10.1 | ||
|
|
||
| - Provide a way to update application process by a known process name | ||
| - Add GetChildProcessById, GetAllProcessByName and some methods to fix issue close/quit application |
There was a problem hiding this comment.
there is no UpdateProcessByName anymore, so let's remove that?
some methods to fix issue close/quit application --> those functions are generally to help working with child process so better --> some methods to interact with child process
There was a problem hiding this comment.
@quangnt this is not addressed as suggested. We need to general this, not too narrow to fix issue close/quit application - because the new functions can be used for general purposes.
|
Commit text, please include JIRA card info |
|
@quangnt Review done, please address comments |
quangnt
force-pushed
the
fix-application-process-exit-after-launching
branch
2 times, most recently
from
d47e659 to
fa67e47
Compare
…ows exception process not found
|
@zelonght @KhanhLanHuynh Addressed LT's comment. Can you have a look? |
|
@quangnt You didn't follow the convention, addressing comments should be in a separated commit. |
|
@quangnt Reviewed done, please address quickly. |
|
👍 // @KhanhLanHuynh @phienpham @longk15t your turn. |
|
ok, will take a look |
3 participants
No description provided.