Added IbmDb2 db2_pclose to disconnect#333
Added IbmDb2 db2_pclose to disconnect#333JargonMan wants to merge 1 commit intozendframework:masterfrom
Conversation
Updated the disconnect method to choose db2_pclose or db2_close based on the resource's connectionParameter for persistence.
Ocramius
left a comment
There was a problem hiding this comment.
Is there any way to test this in integration?
| $p = $this->connectionParameters; | ||
|
|
||
| // given a list of key names, test for existence in $p | ||
| $findParameterValue = function (array $names) use ($p) { |
There was a problem hiding this comment.
Make a new private method returning bool instead. Also, array_change_key_case() is probably a better approach, since nothing guarantees that mIxEDCasE won't be given as parameter.
|
Was this supposed to be closed? |
|
Sorry, I'm new at GitHub and thought the pull request was rejected and I needed to create a new one. |
|
Hah, ok. You can just send more commits to this branch, and that will
update the patch.
…On Tue, 14 Aug 2018, 17:47 JargonMan, ***@***.***> wrote:
Sorry, I'm new at GitHub and thought the pull request was rejected and I
needed to create a new one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakN7hVApH9aE6PaCiLIkrff2QN3Idks5uQvEkgaJpZM4V0pXQ>
.
|
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#27. |
|
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Updated the disconnect method to choose db2_pclose or db2_close based on the resource's connectionParameter for persistence.
The public function connect() creates either persistent or non persistent db2 connections based on a connection parameter.
This update uses the same logic in the public function disconnect() to close the connection. Previously persistent connections would not have been closed with the db2_close() call, because they need the db2_pclose() call.