fix: Do not copy Tomcat configs file when <project>/.smarttomcat/<module>/conf folder is empty#141
Merged
yuezk merged 1 commit intozengkid:masterfrom May 5, 2025
Merged
Conversation
…ule>/conf folder is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the plugin does not check whether the config folder in the working project is empty before copying its contents to the Catalina base folder. If the folder exists but is empty, the plugin proceeds without copying the default Tomcat configuration files, which can lead to runtime errors such as "server.xml not found".
This update ensures that if the working project's config folder is empty, the plugin first populates it with the default Tomcat configuration before copying the files to the Catalina base folder. This prevents missing configuration errors during Tomcat startup.