Skip to content

feat(openapi): add TypeDef support to RPC OpenAPI generator #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Aug 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
efe65ec
merge dev to main (v2.9.2) (#1882)
ymc9 Nov 22, 2024
f5e4e7c
merge dev to main (v2.9.3) (#1886)
ymc9 Nov 26, 2024
251c699
merge dev to main (v2.9.4) (#1892)
ymc9 Nov 27, 2024
7cc5f00
merge dev to main (v2.10.0) (#1907)
ymc9 Dec 5, 2024
f7f85ea
merge dev to main (v2.10.1) (#1913)
ymc9 Dec 13, 2024
689d013
merge dev to main (v2.10.2) (#1919)
ymc9 Dec 18, 2024
70a81c6
merge dev to main (v2.11.0) (#1943)
ymc9 Jan 7, 2025
4b7d813
merge dev to main (v2.11.1) (#1952)
ymc9 Jan 8, 2025
ba80eda
merge dev to main (v2.11.2) (#1957)
ymc9 Jan 13, 2025
b220213
merge dev to main (v2.11.3) (#1963)
ymc9 Jan 14, 2025
ff393da
merge dev to main (v2.11.4) (#1966)
ymc9 Jan 17, 2025
a1dfdcd
merge dev to main (v2.11.5) (#1973)
ymc9 Jan 29, 2025
584d8af
merge dev to main (v2.11.6) (#1981)
ymc9 Feb 7, 2025
0107e1c
merge dev to main (v2.12.0) (#2013)
ymc9 Feb 25, 2025
8934679
merge dev to main (v2.12.1) (#2026)
ymc9 Mar 4, 2025
d4fb5ab
merge dev to main (v2.12.2) (#2032)
ymc9 Mar 7, 2025
a4acf35
merge dev to main (v2.12.3) (#2043)
ymc9 Mar 13, 2025
8a62f63
merge dev to main (v2.13.0) (#2057)
ymc9 Mar 24, 2025
79197c6
merge dev to main (v2.13.1) (#2068)
ymc9 Apr 4, 2025
c017a40
merge dev to main (v2.13.2) (#2072)
ymc9 Apr 7, 2025
2f69aa8
merge dev to main (v2.13.3) (#2076)
ymc9 Apr 9, 2025
bf9be5c
merge dev to main (v2.14.0) (#2086)
ymc9 Apr 15, 2025
88f8c77
merge dev to main (v2.14.0) (#2091)
ymc9 Apr 15, 2025
3895746
merge dev to main (v2.14.1) (#2110)
ymc9 May 5, 2025
b79a749
merge dev to main (v2.14.2) (#2113)
ymc9 May 8, 2025
53bf340
merge dev to main (v2.15.0) (#2126)
ymc9 May 20, 2025
e835599
merge dev to main (v2.15.0) (#2130)
ymc9 May 21, 2025
d8bc32d
merge dev to main (v2.15.0) (#2132)
ymc9 May 21, 2025
19f4870
merge dev to main (v2.15.1) (#2138)
ymc9 Jun 3, 2025
9596d33
merge dev to main (v2.16.0) (#2156)
ymc9 Jun 21, 2025
b73b3de
merge dev to main (v2.16.1) (#2174)
ymc9 Jul 7, 2025
b199ac2
merge dev to main (v2.17.0) (#2191)
ymc9 Jul 20, 2025
1da7440
merge dev to main (v2.17.1) (#2200)
ymc9 Jul 21, 2025
692b714
merge dev to main (v2.17.2) (#2204)
ymc9 Jul 27, 2025
364ede9
feat(openapi): add TypeDef support to RPC OpenAPI generator
olup Aug 14, 2025
3d35bbe
refactor: address code review feedback
olup Aug 16, 2025
95980cb
merge from dev and resolve conflicts
ymc9 Aug 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 80 additions & 4 deletions packages/plugins/openapi/src/rpc-generator.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Inspired by: https://github.com/omar-dulaimi/prisma-trpc-generator

import { PluginError, PluginOptions, analyzePolicies, requireOption, resolvePath } from '@zenstackhq/sdk';
import { DataModel, Model, isDataModel } from '@zenstackhq/sdk/ast';
import { DataModel, Model, TypeDef, TypeDefField, TypeDefFieldType, isDataModel, isEnum, isTypeDef } from '@zenstackhq/sdk/ast';
import {
AggregateOperationSupport,
addMissingInputObjectTypesForAggregate,
Expand Down Expand Up @@ -649,12 +649,27 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {
for (const _enum of [...(this.dmmf.schema.enumTypes.model ?? []), ...this.dmmf.schema.enumTypes.prisma]) {
schemas[upperCaseFirst(_enum.name)] = this.generateEnumComponent(_enum);
}

// Also add enums from AST that might not be in DMMF (e.g., only used in TypeDefs)
for (const enumDecl of this.model.declarations.filter(isEnum)) {
if (!schemas[upperCaseFirst(enumDecl.name)]) {
schemas[upperCaseFirst(enumDecl.name)] = {
type: 'string',
enum: enumDecl.fields.map(f => f.name)
};
}
}

// data models
for (const model of this.dmmf.datamodel.models) {
schemas[upperCaseFirst(model.name)] = this.generateEntityComponent(model);
}

// type defs
for (const typeDef of this.model.declarations.filter(isTypeDef)) {
schemas[upperCaseFirst(typeDef.name)] = this.generateTypeDefComponent(typeDef);
}

for (const input of this.inputObjectTypes) {
schemas[upperCaseFirst(input.name)] = this.generateInputComponent(input);
}
Expand Down Expand Up @@ -737,7 +752,7 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {

const required: string[] = [];
for (const field of model.fields) {
properties[field.name] = this.generateField(field);
properties[field.name] = this.generateField(field, model.name);
if (field.isRequired && !(field.relationName && field.isList)) {
required.push(field.name);
}
Expand All @@ -750,7 +765,22 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {
return result;
}

private generateField(def: { kind: DMMF.FieldKind; type: string; isList: boolean; isRequired: boolean }) {
private generateField(def: { kind: DMMF.FieldKind; type: string; isList: boolean; isRequired: boolean; name?: string }, modelName?: string) {
// For Json fields, check if there's a corresponding TypeDef in the original model
if (def.kind === 'scalar' && def.type === 'Json' && modelName && def.name) {
const dataModel = this.model.declarations.find(d => isDataModel(d) && d.name === modelName) as DataModel;
if (dataModel) {
const field = dataModel.fields.find(f => f.name === def.name);
if (field?.type.reference?.ref && isTypeDef(field.type.reference.ref)) {
// This Json field references a TypeDef
return this.wrapArray(
this.wrapNullable(this.ref(field.type.reference.ref.name, true), !def.isRequired),
def.isList
);
}
}
}

switch (def.kind) {
case 'scalar':
return this.wrapArray(this.prismaTypeToOpenAPIType(def.type, !def.isRequired), def.isList);
Expand Down Expand Up @@ -816,6 +846,47 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {
return result;
}

private generateTypeDefComponent(typeDef: TypeDef): OAPI.SchemaObject {
const schema: OAPI.SchemaObject = {
type: 'object',
description: `The "${typeDef.name}" TypeDef`,
properties: typeDef.fields.reduce((acc, field) => {
acc[field.name] = this.generateTypeDefField(field);
return acc;
}, {} as Record<string, OAPI.ReferenceObject | OAPI.SchemaObject>),
};

const required = typeDef.fields.filter((f) => !f.type.optional).map((f) => f.name);
if (required.length > 0) {
schema.required = required;
}

return schema;
}

private generateTypeDefField(field: TypeDefField): OAPI.ReferenceObject | OAPI.SchemaObject {
return this.wrapArray(
this.wrapNullable(this.typeDefFieldTypeToOpenAPISchema(field.type), field.type.optional),
field.type.array
);
}

private typeDefFieldTypeToOpenAPISchema(type: TypeDefFieldType): OAPI.ReferenceObject | OAPI.SchemaObject {
// For references to other types (TypeDef, Enum, Model)
if (type.reference?.ref) {
return this.ref(type.reference.ref.name, true);
}

// For scalar types, reuse the existing mapping logic
// Note: Json type is handled as empty schema for consistency
return match(type.type)
.with('Json', () => ({} as OAPI.SchemaObject))
.otherwise((t) => {
// Delegate to prismaTypeToOpenAPIType for all other scalar types
return this.prismaTypeToOpenAPIType(String(t), false);
});
}

private setInputRequired(fields: readonly DMMF.SchemaArg[], result: OAPI.NonArraySchemaObject) {
const required = fields.filter((f) => f.isRequired).map((f) => f.name);
if (required.length > 0) {
Expand All @@ -839,7 +910,12 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {
.with(P.union('Boolean', 'True'), () => ({ type: 'boolean' }))
.with('DateTime', () => ({ type: 'string', format: 'date-time' }))
.with('Bytes', () => ({ type: 'string', format: 'byte' }))
.with(P.union('JSON', 'Json'), () => ({}))
.with(P.union('JSON', 'Json'), () => {
// For Json fields, check if there's a specific TypeDef reference
// Otherwise, return empty schema for arbitrary JSON
const isTypeDefType = this.model.declarations.some(d => isTypeDef(d) && d.name === type);
return isTypeDefType ? this.ref(type, false) : {};
})
.otherwise((type) => this.ref(type.toString(), false));

return this.wrapNullable(result, nullable);
Expand Down
Loading
Loading