lib: introduction of the VC8000NanoE video encoder library #295
Conversation
Add VC8000NanoE H264 video encoding stack needed by STM32 VENC peripheral to generate H264 compressed bitstream. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Avoid bool redefinition. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Avoid min/max redefinition. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Add debug trace support. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Fix some debug trace points. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com
Trace pointers in hexa instead of decimal. Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
There was a problem hiding this comment.
Please drop this file - it's large and unneeded. (Also, I'm a bit worried about licensing...)
lib/vc8000nanoe/inc/enccommon.h
Outdated
| #ifndef MAX | ||
| #define MAX(a, b) ((a) > (b) ? (a) : (b)) | ||
| #endif | ||
| #ifndef MIN | ||
| #define MIN(a, b) ((a) < (b) ? (a) : (b)) | ||
| #endif |
There was a problem hiding this comment.
Use of #ifndef is forbidden. See https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-3-macro-name-collisions
There was a problem hiding this comment.
To workaround this, provide and use an alternate definition:
-#define MAX(a, b) ((a) > (b) ? (a) : (b))
+#define STM32_MAX(a, b) ((a) > (b) ? (a) : (b))
There was a problem hiding this comment.
Please add a README filr documenting lib origin, how it is maintained, potential add on fixes. See https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wba/README.rst as exemple
lib/vc8000nanoe/inc/enccommon.h
Outdated
| #ifndef MAX | ||
| #define MAX(a, b) ((a) > (b) ? (a) : (b)) | ||
| #endif | ||
| #ifndef MIN | ||
| #define MIN(a, b) ((a) < (b) ? (a) : (b)) | ||
| #endif |
There was a problem hiding this comment.
To workaround this, provide and use an alternate definition:
-#define MAX(a, b) ((a) > (b) ? (a) : (b))
+#define STM32_MAX(a, b) ((a) > (b) ? (a) : (b))There was a problem hiding this comment.
Sign-off issue on this commit:
-Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com
+Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
This PR introduces the VC8000NanoE software stack needed on top of STM32N6 VENC hardware peripheral in order to enable H264 hardware video compression.
This code comes from STM32CubeN6 firmware code located here: https://github.com/STMicroelectronics/STM32CubeN6/tree/main/Middlewares/Third_Party/VideoEncoder/source
Some changes have been made to comply with Zephyr build system and Zephyr kernel defines.
The debug trace system has been adapted and some trace points fixed.
Defining CONFIG_VENC_DEBUG enable printf trace logs.