lib: stm32wba: 802.15.4 driver integration #311
Conversation
vtardy-st
force-pushed
the
stm32wbax_802154_driver_support
branch
4 times, most recently
from
539e08e to
6631ae3
Compare
vtardy-st
force-pushed
the
stm32wbax_802154_driver_support
branch
from
6631ae3 to
ebe3cdc
Compare
There was a problem hiding this comment.
For clarity, please split your changes in several commits:
- Initial commit(s) that make(s) required modifications prior the introduction of the new library (files moving and sp on)
- Dedicated commit that only introduces new lib + required CMake changes
Last, I don't see changes to the library update scripts. I really think this should be added to help maintainance
What is the plan for library update ?
There was a problem hiding this comment.
I'm fine with removing this file, but modifications to the existing files should be done in a dedicated commit with proper justification.
There was a problem hiding this comment.
This change is revert because it requires rework
There was a problem hiding this comment.
Modifications to the existing files should be done in a dedicated commit to ease the review.
There was a problem hiding this comment.
This change is revert because it requires rework
rename ble folder and add/change CMakeList Signed-off-by: Vincent Tardy <vincent.tardy@st.com>
Add 802.15.4 driver integration Signed-off-by: Vincent Tardy <vincent.tardy@st.com>
vtardy-st
force-pushed
the
stm32wbax_802154_driver_support
branch
from
ebe3cdc to
89b8400
Compare
|
Changes included in this PR have been splitted in 2 commits :
|
| zephyr_include_directories(ble/stack/include) | ||
| zephyr_include_directories(ble/stack/include/auto) |
There was a problem hiding this comment.
Please make use of indentation in CMakeLists file. Apply everywhere
| zephyr_include_directories(${CMAKE_CURRENT_SOURCE_DIR}) | ||
|
|
||
| add_subdirectory(ll_sys) |
| @@ -0,0 +1,11 @@ | |||
| # Copyright (c) 2024 STMicroelectronics | |||
| @@ -0,0 +1,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
Add header with license and copyright in each file
| zephyr_sources(src/ll_sys_cs.c) | ||
| zephyr_sources(src/ll_sys_dp_slp.c) | ||
| zephyr_sources(src/ll_sys_intf.c) | ||
| zephyr_sources(src/ll_sys_startup.c) |
There was a problem hiding this comment.
Missing end of line at the end of file.
To be fixed in each new file
There was a problem hiding this comment.
Sorry for the review split in multiple comments, this will be the last one.
I'm not opposed to reshuffling the CMakeLists.txt, and this probably welcome given the introduction of a new library and the fact that some components are shared between the 2.
Though, I think current proposal goes to far in this direction and makes things quite difficult to follow.
I'd propose to limit to 3/4 files instead of the 6 proposed currently (in my view, lesser is better, but I may miss technical constraints)
| if (CONFIG_BT_STM32WBA) | ||
| zephyr_compile_definitions( -DBLE ) | ||
| endif() |
There was a problem hiding this comment.
I don't think there is an interest to put this down in this file as zephyr_compile_definitions isn't scoped and will apply to the whole library anyway.
lib/stm32wba/CMakeLists.txt
Outdated
|
|
||
| add_subdirectory(STM32_WPAN) | ||
|
|
||
| add_subdirectory_ifdef(CONFIG_BT_STM32WBA ble) |
There was a problem hiding this comment.
Putting these instructions after the linking instructions doesn't feel quite clean.
| zephyr_include_directories(${CMAKE_CURRENT_SOURCE_DIR}) | ||
|
|
||
| zephyr_include_directories(inc) | ||
| zephyr_include_directories(../ll_cmd_lib/inc) | ||
| zephyr_include_directories(../ll_cmd_lib/inc/_40nm_reg_files) |
There was a problem hiding this comment.
Despite the addition of multiple CMakeLists.txt files, we're ending up including files from outside components.
This is probably a sign we've been to deep into CMakeLists file splitting.
It's a draft version to retrieve a first review
Add 802.15.4 driver integration
In the lib\stm32wba, 'BLE_TransparentMode' folder has been renamed 'ble'.
Add CMakeLists.txt file in /ble folder
Add IEEE802154 folder