Skip to content

drivers: current_sense: add offset binding #87988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

drivers: current_sense: add offset binding #87988

merged 1 commit into from
May 28, 2025

Conversation

brandon-exact
Copy link
Contributor

@brandon-exact brandon-exact commented Apr 1, 2025 •
edited
Loading

some current sense amplifiers have a non zero offset voltage
that correlates to zero current. adding this offset voltage binding
allows the driver to be used with this type of circuitry.

Signed-off-by: Brandon Allen brandon.allen@exacttechnology.com

@github-actions github-actions bot added area: Devicetree area: ADC Analog-to-Digital Converter (ADC) labels Apr 1, 2025
rruuaanng
rruuaanng previously approved these changes Apr 2, 2025
View reviewed changes
rruuaanng
rruuaanng reviewed Apr 2, 2025
View reviewed changes
mbolivar
mbolivar previously requested changes Apr 2, 2025
View reviewed changes
dts/bindings/iio/afe/current-sense-amplifier.yaml Outdated
type: int
default: 0
description: |
The zero current voltage in mV. The default is <0>. The maximum value is <65535>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please read https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#rules-for-default-values and fix this

@brandon-exact brandon-exact requested a review from mbolivar April 3, 2025 16:37
@brandon-exact
Copy link
Contributor Author

brandon-exact commented Apr 3, 2025 •
edited
Loading

for more context, here is screenshot of the current sensors datasheet I used in the test
image

@fabiobaltieri I noticed you reviewed the initial PR for this, maybe you could take a look aswell and let me know what you think? Maybe an alternative would be to setup a new binding called current-sense-opamp?

fabiobaltieri
fabiobaltieri previously approved these changes Apr 4, 2025
View reviewed changes
@fabiobaltieri fabiobaltieri assigned mbolivar and unassigned mbolivar Apr 4, 2025
fabiobaltieri
fabiobaltieri reviewed Apr 4, 2025
View reviewed changes
JordanYates
JordanYates requested changes Apr 4, 2025
View reviewed changes
@github-actions github-actions bot added the area: Sensors Sensors label Apr 4, 2025
@brandon-exact
Copy link
Contributor Author

resolved conflicts

JordanYates
JordanYates previously approved these changes Apr 9, 2025
View reviewed changes
@brandon-exact
Copy link
Contributor Author

Im not sure why that test failed; I do not see it failing on main and my branch is rebased. Anything I need to do?

@JordanYates
Copy link
Collaborator

JordanYates commented Apr 10, 2025 •
edited
Loading

Im not sure why that test failed; I do not see it failing on main and my branch is rebased. Anything I need to do?

I have seen that test fail on some of my PRs as well, it is unrelated. Just unlucky that twister decided that it should be part of this PR's testplan. You don't need to do anything.

Created #88396

fabiobaltieri
fabiobaltieri previously approved these changes Apr 10, 2025
View reviewed changes
@brandon-exact
Copy link
Contributor Author

@mbolivar gentle ping

yperess
yperess previously approved these changes Apr 11, 2025
View reviewed changes
kartben
kartben reviewed May 14, 2025
View reviewed changes
@brandon-exact
drivers: current_sense_amplifier: add zero-current-voltage binding
f401f68 
some current sense amplifiers have a non zero offset voltage
that correlates to zero current. adding this offset voltage binding
allows the driver to be used with this type of circuitry.

Signed-off-by: Brandon Allen <brandon.allen@exacttechnology.com>
@brandon-exact brandon-exact dismissed stale reviews from yperess, fabiobaltieri, and JordanYates via f401f68 May 15, 2025 17:18
@brandon-exact brandon-exact requested a review from kartben May 15, 2025 17:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 979933c into zephyrproject-rtos:main May 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@JordanYates JordanYates JordanYates approved these changes

@anangl anangl Awaiting requested review from anangl

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

@mbolivar mbolivar Awaiting requested review from mbolivar

@avisconti avisconti Awaiting requested review from avisconti

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@ubieda ubieda Awaiting requested review from ubieda

@rruuaanng rruuaanng Awaiting requested review from rruuaanng

@yperess yperess Awaiting requested review from yperess

Assignees

@mbolivar mbolivar

@MaureenHelm MaureenHelm

Labels
area: ADC Analog-to-Digital Converter (ADC) area: Devicetree area: Sensors Sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@brandon-exact @JordanYates @mbolivar @kartben @fabiobaltieri @MaureenHelm @yperess @rruuaanng