Skip to content

drivers: can: renesas: improve Renesas RA CAN driver implementation #89717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

thenguyenyf
Copy link
Collaborator

Apply these changes to avoid undefine issue on Renesas RA CAN:

  • Keep data inside instance data and remove data accessing by HAL pointer
  • Remove unnecessary CAN bus starting at initial function

Keep data instance inside of data structure.
Avoid accessing global data or using pointers to out of
data instance.

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Remove can bus starting at initial function

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link

sonarqubecloud bot commented May 9, 2025

@thenguyenyf
Copy link
Collaborator Author

Hello @thaoluonguw , @duynguyenxa . Could you please take a look?

Copy link
Collaborator

@thaoluonguw thaoluonguw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK with me.

@thenguyenyf thenguyenyf added this to the v4.2.0 milestone May 21, 2025
@thenguyenyf
Copy link
Collaborator Author

Hello @KhiemNguyenT , @soburi . Could you please take a look?

@henrikbrixandersen
Copy link
Member

Hello @KhiemNguyenT , @soburi . Could you please take a look?

@KhiemNguyenT, @soburi Please take a look.

@kartben kartben merged commit bd87dbc into zephyrproject-rtos:main May 29, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CAN platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants