Skip to content

Add support for IW610 #89875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gangli02
Copy link
Contributor

Add Kconfig NXP_IW610, NXP_IW610_MURATA_2LL_M2, NXP_IW610_RD_USD.
Added seperate shield overlay for supported M.2 2LL module to enable BT or WIFI or Both.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would probably be better to use the following naming scheme for the shields nxp_m2_wifi_bt_XXX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is consistent with other m2 shields. (nxp_m2_1xk_wifi_bt, nxp_m2_2el_wifi_bt)
m2_1xk, m2_2el, m2_2ll are types of m2 shield, maybe nxp_m2_XXX_wifi_bt or nxp_wifi_bt_m2_XXX are better, right?
@abhinavnxp @nirav-agrawal what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gangli02, we kept wifi_bt post m.2 type to aware that the shield supports both Wi-Fi and BT interface of xxx type of m.2 module. In future, there would be m2 module that may support either BT or Wi-Fi.

@gangli02 gangli02 force-pushed the main_nighthwak branch 2 times, most recently from 6f397dc to 4ae998c Compare May 19, 2025 02:27
Copy link

github-actions bot commented May 19, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@2fe4ab6 zephyrproject-rtos/hal_nxp#534 zephyrproject-rtos/hal_nxp#534/files

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_nxp 3x 🆕

DNM label due to: 1 project with PR revision, 1 project with metadata changes and 3 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 19, 2025
MaochenWang1
MaochenWang1 previously approved these changes May 19, 2025
@gangli02 gangli02 requested a review from kartben May 19, 2025 08:38
Copy link
Contributor

@nirav-agrawal nirav-agrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gangli02, changes are ok for the Shield addition and for BT part, let other folks to review and approve.

decsny
decsny previously approved these changes May 21, 2025
@dleach02
Copy link
Member

The open/close is to kick off the new action to get the new blobs label to apply

@dleach02 dleach02 closed this May 29, 2025
@dleach02 dleach02 reopened this May 29, 2025
@gangli02 gangli02 dismissed stale reviews from decsny and MaochenWang1 via 097e0f3 May 29, 2025 03:33
@gangli02 gangli02 force-pushed the main_nighthwak branch 3 times, most recently from 277c27d to 9a77600 Compare May 29, 2025 06:05
gangli02 and others added 4 commits June 3, 2025 05:13
Add Kconfig NXP_IW610, NXP_IW610_MURATA_2LL_M2,
NXP_IW610_RD_USD

Signed-off-by: Gang Li <gang.li_1@nxp.com>
Added seperate shield overlay for supported M.2 2LL module to enable
 BT or WIFI or Both.

Signed-off-by: Gang Li <gang.li_1@nxp.com>
Add Kconfig BT_NXP_IW610.

Signed-off-by: Guotao Zhang <guotao.zhang@nxp.com>
Add support for IW610

Signed-off-by: Gang Li <gang.li_1@nxp.com>
Copy link

sonarqubecloud bot commented Jun 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth area: Shields Shields (add-on boards) area: Wi-Fi Wi-Fi Binary Blobs Added DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants