-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Add support for IW610 #89875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for IW610 #89875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it would probably be better to use the following naming scheme for the shields nxp_m2_wifi_bt_XXX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is consistent with other m2 shields. (nxp_m2_1xk_wifi_bt, nxp_m2_2el_wifi_bt)
m2_1xk, m2_2el, m2_2ll are types of m2 shield, maybe nxp_m2_XXX_wifi_bt or nxp_wifi_bt_m2_XXX are better, right?
@abhinavnxp @nirav-agrawal what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gangli02, we kept wifi_bt post m.2 type to aware that the shield supports both Wi-Fi and BT interface of xxx type of m.2 module. In future, there would be m2 module that may support either BT or Wi-Fi.
6f397dc
to
4ae998c
Compare
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with PR revision, 1 project with metadata changes and 3 blob changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gangli02, changes are ok for the Shield addition and for BT part, let other folks to review and approve.
The open/close is to kick off the new action to get the new blobs label to apply |
277c27d
to
9a77600
Compare
Add Kconfig NXP_IW610, NXP_IW610_MURATA_2LL_M2, NXP_IW610_RD_USD Signed-off-by: Gang Li <gang.li_1@nxp.com>
Added seperate shield overlay for supported M.2 2LL module to enable BT or WIFI or Both. Signed-off-by: Gang Li <gang.li_1@nxp.com>
Add Kconfig BT_NXP_IW610. Signed-off-by: Guotao Zhang <guotao.zhang@nxp.com>
Add support for IW610 Signed-off-by: Gang Li <gang.li_1@nxp.com>
|
Add Kconfig NXP_IW610, NXP_IW610_MURATA_2LL_M2, NXP_IW610_RD_USD.
Added seperate shield overlay for supported M.2 2LL module to enable BT or WIFI or Both.