Bluetooth: ASCS: Sonarcloud fixes

[Thalley]

Made a few complex functions simpler
Added missing default cases in switches
Fixes a bad cast that removed const
Moved loop iterators to inner loop

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This pull request primarily simplifies several complex functions in the Bluetooth ASCS module while addressing SonarCloud issues. Key changes include adding missing default cases in switch statements, refactoring error‐handling checks (using “if (err != 0)” in place of “if (err)”), and introducing a multi-CCID existence check.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
subsys/bluetooth/audio/cap_internal.h	Added prototype for checking multiple CCIDs existence.
subsys/bluetooth/audio/cap_acceptor.c	Implemented a new function to validate multiple CCIDs and introduced related logging comments.
subsys/bluetooth/audio/ascs_internal.h	Added default cases in various inline string conversion functions.
subsys/bluetooth/audio/ascs.c	Refactored error checking, loop index types, codec configuration, and overall error handling.

Comments suppressed due to low confidence (3)

subsys/bluetooth/audio/ascs.c:1670

• [nitpick] Downgrading the error log to debug level in a failure case may obscure critical issues; please confirm that this change in log level is intentional.

LOG_DBG("Config failed: err %d, stream %p, code %u, reason %u", err, stream, rsp.code, rsp.reason);

subsys/bluetooth/audio/ascs.c:2175

• Since data_len is used as the CCID count, please verify that it accurately represents the number of CCIDs provided to prevent unexpected behavior if the metadata format changes.

if (IS_ENABLED(CONFIG_BT_CAP_ACCEPTOR) && !bt_cap_acceptor_ccids_exist(result->ep->stream->conn, data_value, data_len)) {

subsys/bluetooth/audio/ascs.c:2436

• [nitpick] Ensure that using a uint8_t for the loop index is appropriate given the expected range of req->num_ases to avoid potential overflow issues.

for (uint8_t i = 0U; i < req->num_ases; i++) {