Skip to content

Add nxp edac driver #94111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add nxp edac driver #94111

wants to merge 5 commits into from
+956 −18

Conversation

@yvesll
Copy link
Contributor

@yvesll yvesll commented Aug 5, 2025

Added NXP's EDAC implementation based on EIM and ERM

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Hello @yvesll, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

decsny
decsny reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

@yvesll
Copy link
Contributor Author

yvesll commented Aug 9, 2025 •
edited
Loading

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

You are correct, the virtual edac node and independent eim channel binding are redundant here.
I will only keep erm for error reporting and eim for error injection.

@yvesll yvesll force-pushed the add-nxp-edac-driver branch from e694c25 to be74c15 Compare August 11, 2025 07:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 11, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Holt-Sun
Holt-Sun reviewed Sep 16, 2025
View reviewed changes
@Holt-Sun
Copy link
Contributor

Holt-Sun commented Sep 16, 2025

Quality Gate passed

Please fix the issue in "Quality Gate passed".

@yvesll yvesll force-pushed the add-nxp-edac-driver branch from be74c15 to 815fb39 Compare September 17, 2025 01:50
@zephyrbot zephyrbot requested a review from decsny September 17, 2025 01:51
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 815fb39 to 971b938 Compare September 18, 2025 07:32
kartben
kartben previously approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for docs. Thank you!

@Holt-Sun Holt-Sun self-requested a review November 21, 2025 05:37
Holt-Sun
Holt-Sun previously approved these changes Nov 21, 2025
View reviewed changes
@yvesll
Copy link
Contributor Author

yvesll commented Nov 21, 2025

THis PR depends on zephyrproject-rtos/hal_nxp#629

zejiang0jason
zejiang0jason reviewed Nov 21, 2025
View reviewed changes
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 09eebf7 to 43054af Compare November 21, 2025 14:57
@zephyrbot zephyrbot requested a review from kartben November 21, 2025 14:59
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from 43054af to 733163c Compare November 21, 2025 15:32
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@a7f64ac zephyrproject-rtos/hal_nxp@c4824f7 (master) zephyrproject-rtos/hal_nxp@a7f64ac2..c4824f70

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@mmahadevan108
Copy link
Contributor

mmahadevan108 commented Nov 21, 2025

@finikorg , please provide feedback on the change made to the sample. I don't see the change made to platforms that already run this sample.

zejiang0jason
zejiang0jason previously approved these changes Nov 25, 2025
View reviewed changes
yvesll and others added 5 commits November 25, 2025 13:53
@yvesll
drivers: edac: Add NXP EDAC driver
69a7940 
Add edac driver for NXP's ERM and EIM peripherals. It can inject ECC
error to specific channel within EIM and then report the error address,
syndrome and count within ERM.

Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>
@yvesll
dts: nxp: add edac support for MCX platforms
3f96989 
Add eim, erm and edac instance for frdm_mcxa153, frdm_mcxn236,
frdm_mcxn947, frdm_mcxe247 and frdm_mcxe31b.

Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>
@yvesll
samples: edac: update the app to support more platforms
987e593 
Decouple the edac sample with IBECC.

Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>
@yvesll
doc: Update edac shell sample's readme
6c7c8b5 
Update the console log in readme to make it aligned with the actual
output

Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>
@mmahadevan108 @yvesll
west.yml: Update hal nxp to get changes for eim and erm
733b48a 
Get changes to the SDK driver

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@yvesll yvesll force-pushed the add-nxp-edac-driver branch from bbd9897 to 733b48a Compare November 25, 2025 05:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yvesll yvesll dismissed stale reviews from zejiang0jason and Holt-Sun via 733b48a November 25, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Holt-Sun Holt-Sun Holt-Sun approved these changes

@zejiang0jason zejiang0jason zejiang0jason approved these changes

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@butok butok Awaiting requested review from butok

@dbaluta dbaluta Awaiting requested review from dbaluta

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@finikorg finikorg Awaiting requested review from finikorg

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

@manuargue manuargue Awaiting requested review from manuargue

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@decsny decsny Awaiting requested review from decsny

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

@kartben kartben Awaiting requested review from kartben

Assignees

@finikorg finikorg

Labels

area: Boards/SoCs area: Devicetree Bindings area: EDAC area: Linters area: Samples Samples manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MCU platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@yvesll @Holt-Sun @decsny @mmahadevan108 @kartben @zejiang0jason @keith-zephyr @finikorg @zephyrbot