-
Notifications
You must be signed in to change notification settings - Fork 8.4k
modules: Update trusted-firmware-m for picolibc #94367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: Update trusted-firmware-m for picolibc #94367
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 2 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
10352ce to
e203de9
Compare
|
This is waiting for zephyr SDK 0.17.4 |
|
Hi @keith-packard , I would like to printout that #94470 shows that arm platform needs some fixes. I'm not sure if that affects your CI tests. |
Thanks. It's also blocked on the SDK at present, so once that's merged I'll see what else is broken. |
e203de9 to
d5baa3b
Compare
d5baa3b to
ea7909d
Compare
|
All seems to work fine with just this patch. |
tomi-font
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need some competent people (not me) to review the TF-M changes
ea7909d to
1735747
Compare
|
|
I've restructured the tf-m patch a bunch, fixing all of the linker scripts instead of just those used by Zephyr CI and removing the TLS changes as they aren't required with current tf-m code. Overall, the changes are a whole lot cleaner now, I'm hoping they'll be easier to review as a result. |
1735747 to
cb0a83c
Compare
cb0a83c to
439a62c
Compare
This adds linker script bits and compiler options so that trusted-firmware-m will build with picolibc. This has not been merged to the Zephyr trusted-firmware-m repository yet, that PR is: zephyrproject-rtos/trusted-firmware-m#134 Signed-off-by: Keith Packard <keithp@keithp.com>
This module also needs some small changes to build with picolibc. This has not been merged to the Zephyr tf-m-tests repository yet, that PR is: zephyrproject-rtos/tf-m-tests#17 Signed-off-by: Keith Packard <keithp@keithp.com>
439a62c to
f44864e
Compare
|
I added a PR for tf-m-tests to this as well; there were some minor picolibc compatibility changes needed once I discovered that the Zephyr build had disabled assert(0) when building these tests. |
|
|
|
(sorry, must have clicked 'close' by mistake) |
|
re-opening without the tf-m-tests change |
|
Oof. I'm not sure what's up with github, but I can't get this PR re-opened. I've re-created it as #100544 |
|
Probably because you have force-pushed your branch since the close? |
Probably so. The ways of github are sometimes mysterious. In any case, thanks for the review of #100544. |



This adds linker script bits and compiler options so that trusted-firmware-m will build with picolibc.
This has not been merged to the Zephyr trusted-firmware-m repository yet, that PR is zephyrproject-rtos/trusted-firmware-m#134