Skip to content

Conversation

@keith-packard
Copy link
Contributor

This adds linker script bits and compiler options so that trusted-firmware-m will build with picolibc.

This has not been merged to the Zephyr trusted-firmware-m repository yet, that PR is zephyrproject-rtos/trusted-firmware-m#134

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Aug 11, 2025
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
tf-m-tests zephyrproject-rtos/tf-m-tests@a90702b (main,zephyr_tf-m-tests_v2.2.0) zephyrproject-rtos/tf-m-tests#17 zephyrproject-rtos/tf-m-tests#17/files
trusted-firmware-m zephyrproject-rtos/trusted-firmware-m@c2f9edc (main,zephyr_tf-m_v2.2.0) zephyrproject-rtos/trusted-firmware-m#134 zephyrproject-rtos/trusted-firmware-m#134/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@keith-packard
Copy link
Contributor Author

This is waiting for zephyr SDK 0.17.4

@nandojve
Copy link
Member

Hi @keith-packard ,

I would like to printout that #94470 shows that arm platform needs some fixes. I'm not sure if that affects your CI tests.

@keith-packard
Copy link
Contributor Author

Hi @keith-packard ,

I would like to printout that #94470 shows that arm platform needs some fixes. I'm not sure if that affects your CI tests.

Thanks. It's also blocked on the SDK at present, so once that's merged I'll see what else is broken.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

@keith-packard
Copy link
Contributor Author

Hi @keith-packard ,
I would like to printout that #94470 shows that arm platform needs some fixes. I'm not sure if that affects your CI tests.

Thanks. It's also blocked on the SDK at present, so once that's merged I'll see what else is broken.

All seems to work fine with just this patch.

tomi-font
tomi-font previously approved these changes Sep 29, 2025
Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need some competent people (not me) to review the TF-M changes

@sonarqubecloud
Copy link

@keith-packard
Copy link
Contributor Author

I've restructured the tf-m patch a bunch, fixing all of the linker scripts instead of just those used by Zephyr CI and removing the TLS changes as they aren't required with current tf-m code. Overall, the changes are a whole lot cleaner now, I'm hoping they'll be easier to review as a result.

@valeriosetti valeriosetti removed their request for review October 29, 2025 21:11
This adds linker script bits and compiler options so that
trusted-firmware-m will build with picolibc.

This has not been merged to the Zephyr trusted-firmware-m repository yet,
that PR is:

zephyrproject-rtos/trusted-firmware-m#134

Signed-off-by: Keith Packard <keithp@keithp.com>
This module also needs some small changes to build with picolibc.

This has not been merged to the Zephyr tf-m-tests repository yet,
that PR is:

zephyrproject-rtos/tf-m-tests#17

Signed-off-by: Keith Packard <keithp@keithp.com>
@zephyrbot zephyrbot removed the size: XS A PR changing only a single line of code label Dec 4, 2025
@keith-packard
Copy link
Contributor Author

I added a PR for tf-m-tests to this as well; there were some minor picolibc compatibility changes needed once I discovered that the Zephyr build had disabled assert(0) when building these tests.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@keith-packard
Copy link
Contributor Author

I added a PR for tf-m-tests to this as well; there were some minor picolibc compatibility changes needed once I discovered that the Zephyr build had disabled assert(0) when building these tests.

@keith-packard
Copy link
Contributor Author

(sorry, must have clicked 'close' by mistake)

@keith-packard
Copy link
Contributor Author

re-opening without the tf-m-tests change

@keith-packard
Copy link
Contributor Author

Oof. I'm not sure what's up with github, but I can't get this PR re-opened. I've re-created it as #100544

@tomi-font
Copy link
Contributor

Probably because you have force-pushed your branch since the close?

@keith-packard
Copy link
Contributor Author

Probably because you have force-pushed your branch since the close?

Probably so. The ways of github are sometimes mysterious. In any case, thanks for the review of #100544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: TF-M ARM Trusted Firmware-M (TF-M) DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-tf-m-tests manifest-trusted-firmware-m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants