boards: efm32gg11: Enable Si7210 Hall-effect sensor

[Silicon-Signals]

Enable Si7210 Hall-effect sensor node under I2C2 in slstk3701a DTS for magnetic field sensing. Include a 3.3V fixed regulator (sensor-enable) via GPIO for power control.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jerome-pouiller]

About the commit log:

• the title should start with boards: silabs: slstk3701a: (the name of the board is slstk3701a, not efm32gg11).
• Signed-off-by: must be associated to an individual. siliconsignalsforgit@gmail.com is not valid.

Otherwise, fine.

[Silicon-Signals]

@jerome-pouiller

Thanks for the feedback

About the commit log:

• the title should start with boards: silabs: slstk3701a: (the name of the board is slstk3701a, not efm32gg11).

Sure, will change it.

• Signed-off-by: must be associated to an individual. siliconsignalsforgit@gmail.com is not valid.

I understand that Zephyr's guidelines require the email to match the one used to author the commit and that it shouldn't be a no-reply or anonymized address. However, the email address siliconsignalsforgit@gmail.com
is actively managed by an individual on our team, not a generic no-reply address. It is being used to represent contributions from the team, but it is indeed associated with an actual person.

Given this, I would prefer to retain this SoB.

For reference, we've used the same sign-off (with siliconsignalsforgit@gmail.com) in a previous PR: #91173

[jerome-pouiller]

[...]

• Signed-off-by: must be associated to an individual. siliconsignalsforgit@gmail.com is not valid.

I understand that Zephyr's guidelines require the email to match the one used to author the commit and that it shouldn't be a no-reply or anonymized address. However, the email address siliconsignalsforgit@gmail.com is actively managed by an individual on our team, not a generic no-reply address. It is being used to represent contributions from the team, but it is indeed associated with an actual person.

Given this, I would prefer to retain this SoB.

For reference, we've used the same sign-off (with siliconsignalsforgit@gmail.com) in a previous PR: #91173

@MaureenHelm, @pdgendt, was it an oversight or do you confirm this complies with the guidelines?

[pdgendt]

@MaureenHelm, @pdgendt, was it an oversight or do you confirm this complies with the guidelines?

Erm, I don't know. Should ask the experts here @kartben @keith-zephyr

[kartben]

I think the guidelines are pretty clear - you must "use your legal name (pseudonyms, hacker handles, and the names of groups are not allowed)"
https://docs.zephyrproject.org/latest/contribute/guidelines.html#dco-sign-off

I personally have no issues with the email address per-se (it's really not so different from e.g. jane.doe+githubstuff@gmail.com), as long as there is a "real" author in front of it.

[jerome-pouiller]

@Silicon-Signals, you can use (assuming you are Elgin Perumbilly):

Signed-off-by: Elgin Perumbilly <siliconsignalsforgit@gmail.com>

(@kartben, correct me if I am wrong)

[Silicon-Signals]

@jerome-pouiller

We are using the same SoB for all developments in Zephyr across our company to ensure that our work can be easily tracked.

I am not breaking any rules according to Zephyr's guidelines.

As @kartben mentioned, as long as there is a "real" author listed, there shouldn't be any issues, so I prefer to let it be.

[kartben]

We are using the same SoB for all developments in Zephyr across our company to ensure that our work can be easily tracked.

I have to admit that I am really missing your point here? Is it any harder to track commits authored by someone with an email address from your domain?

I am not breaking any rules according to Zephyr's guidelines.

See below :)

As @kartben mentioned, as long as there is a "real" author listed, there shouldn't be any issues, so I prefer to let it be.

You might have misunderstood me. The guidelines are pretty clear and the git author should be a real person's legal name.

[Silicon-Signals]

@jerome-pouiller @kartben

I am closing this PR.
Elgin has sent a new PR with his SoB and also changed the subject line.

Link PR: #95405

[kartben]

@jerome-pouiller @kartben

I am closing this PR. Elgin has sent a new PR with his SoB and also changed the subject line.

Link PR: #95405

you really shouldn't be doing this though :) Amending the commit from this PR would have been much preferred.

[Silicon-Signals]

@jerome-pouiller @kartben
I am closing this PR. Elgin has sent a new PR with his SoB and also changed the subject line.
Link PR: #95405

you really shouldn't be doing this though :) Amending the commit from this PR would have been much preferred.

Sorry about that. I should have asked you before doing this.