Skip to content

Conversation

kbidani
Copy link
Contributor

@kbidani kbidani commented Sep 2, 2025

Removed the '#define PAGESIZE CONFIG_POSIX_PAGE_SIZE' line from posix_limits.h.
This resolves a build issue caused by macro substitution when PAGESIZE is used as an identifier in some code.

This fix resolves a build issue caused by macro substitution
when PAGESIZE is used as an identifier in some code.

Signed-off-by: Khaoula Bidani <khaoula.bidani-ext@st.com>
@kbidani kbidani marked this pull request as ready for review September 2, 2025 14:41
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: POSIX POSIX API Library labels Sep 2, 2025
@zephyrbot zephyrbot requested review from cfriedt and ycsin September 2, 2025 14:41
Copy link

sonarqubecloud bot commented Sep 2, 2025

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove standard macros names.

@cfriedt
Copy link
Member

cfriedt commented Sep 3, 2025

@kbidani - this is a known issue with STM previously.

I'm not sure what the previous solution was (probably an #undef in the HAL file?) but it would be good to re-use the previous solution.

CC @erwango

@erwango
Copy link
Member

erwango commented Sep 4, 2025

@kbidani - this is a known issue with STM previously.

I'm not sure what the previous solution was (probably an #undef in the HAL file?) but it would be good to re-use the previous solution.

CC @erwango

Indeed, this is fixed in hals today:
https://github.com/zephyrproject-rtos/hal_stm32/blob/main/stm32cube/stm32f4xx/drivers/include/Legacy/stm32_hal_legacy.h#L475

This should indeed be extended to new series (MP13, MP2, N6, U3, ...) when not the case already.

@kbidani kbidani closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants