dt-bindings: sensor: lsm9ds1: Fix misleading descriptions #95351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LSM9DS1 bindings were described as a full 9-axis IMU, while each binding only covers one part of the device. This also made the "Supported features" section of the generated docs misleading, since it only shows the first sentence. Update the descriptions to explicitly state whether they cover the accelerometer + gyroscope or the magnetometer. Signed-off-by: Miguel Gazquez <miguel.gazquez@bootlin.com>
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
|
MaureenHelm
approved these changes
Sep 3, 2025
|
But why is this two different bindings in the first place, this seems wrong? |
Even if the lsm9ds1 is only one chip, on a logical view it's really two devices : the accel+gyro part and the magn part have a different set of register, different I²C address when on a I²C bus, and different pins for the Chip Select when on a SPI bus. So it is implemented as two different driver, with two different compatible, this seemed the most logical way to do this to me. The lsm9ds0 is implemented in the same way. |
yperess
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSM9DS1 bindings were described as a full 9-axis IMU, while each binding only covers one part of the device. This also made the "Supported features" section of the generated docs misleading, since it only shows the first sentence.
Update the descriptions to explicitly state whether they cover the accelerometer + gyroscope or the magnetometer.