posix: c_lib_ext: fnmatch: add support for posix character classes

[Spago123]

Fixed failling tests in fnmatch.c test file.
Removed duplicated code and added simplicfications.
Added new test cases.

Stepts to test run: west build -p -b qemu_cortex_a53 -t run tests/posix/c_lib_ext/
in the shell and you shall get the next result:
- PASS - [posix_c_lib_ext.test_fnmatch] duration = 0.001 seconds

Fixes #55186

[github-actions]

Hello @Spago123, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[cfriedt]

@Spago123 - really nice, thanks!

Just a couple of housekeeping requests.

I like that you've broken this up into separate commits, but can the commits be redone in this order:

1. Code commit that adds the new functionality ("alpha", etc matching)
2. Add just the tests for "alpha", etc
3. Optimizations to reduce duplicate code, etc
4. Doxygen

Please make sure the commit messages are really clear about what is being done and why in each commit.

[Spago123]

@Spago123 - really nice, thanks!

Just a couple of housekeeping requests.

I like that you've broken this up into separate commits, but can the commits be redone in this order:

1. Code commit that adds the new functionality ("alpha", etc matching)

2. Add just the tests for "alpha", etc

3. Optimizations to reduce duplicate code, etc

4. Doxygen

Please make sure the commit messages are really clear about what is being done and why in each commit.

Yup I reorderd and split the needed commit as you suggested

[cfriedt]

@Spago123 - some CI errors related to islower() and ispunct(), which are often defined as macros.

[Spago123]

@Spago123 - some CI errors related to islower() and ispunct(), which are often defined as macros.

Yup it seems there is an issue with those fucntions on some platforms, I added custom implementations that satistify the library definitions

[cfriedt]

@Spago123 - will be looking to get this merged soon after v4.3.0 is released. I'll revisit shortly to see if I can help to correct any issues.

[Spago123]

@Spago123 - will be looking to get this merged soon after v4.3.0 is released. I'll revisit shortly to see if I can help to correct any issues.

Lovely. I am not sure for the documentation pipline what excatly is the issue

[cfriedt]

@Spago123 - this is really really close - great work! It's testing locally for me fine with some minor modification.

I added some comments and suggestions.

In terms of the doc build issue, it's passing on main (ref), so I would suggest switching back to main, pulling, and then rebasing your bugfix/harunspago/55186_fnmatch_known_bug on top of main again.

[cfriedt]

I'm also not sure if the commit posix: c_lib_ext: fnmatch: added suppor for missing posix functions is needed. It might be best to drop it.

Ah, I see - those functions are missing in the minimal libc.

I've added them in #99451

[Spago123]

I'm also not sure if the commit posix: c_lib_ext: fnmatch: added suppor for missing posix functions is needed. It might be best to drop it.

Ah, I see - those functions are missing in the minimal libc.

I've added them in #99451

I removed the commit and now I am back at using the islower, ispunct and is blank functions as in the first place :)

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud