lib/posix: Adopt newlib-style re-entrant API for getopt family #99450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: POSIX
zephyrbot
requested review from
MaochenWang1,
aaronemassey,
carlescufi,
cfriedt,
jakub-uC,
jeremybettis,
jukkar,
krish2718,
nashif,
pdgendt,
rlubos,
ssharks,
thenguyenyf,
ycsin and
yperess
keith-packard
force-pushed
the
getopt_r
branch
from
db4f6e8 to
8386de9
Compare
keith-packard
force-pushed
the
getopt_r
branch
3 times, most recently
from
dc2c298 to
7758f98
Compare
Replace the Zephyr-specific re-entrant getopt family APIs with those from newlib. This allows use of the newlib and picolibc native implementations and provides a cleaner re-entrant mechanism, using a local variable to hold the getopt state instead of having a thread-local variabled tucked away in the shell context. This will require changing all re-entrant users of getopt, switching from the Zephyr-style interfaces to the newlib-style. This also adopts the glibc/picolibc convention where setting optind = 0 causes the getopt functions to re-initialize all parsing state. This lets us test the non-reentrant API without needing getopt_init(). Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
getopt_r
branch
from
7758f98 to
81ef7d6
Compare
The code scanner appears to believe that cmd_buff is of size zero and complains about it. Protect an assignment to cmd_buff[0] with a #if check. Signed-off-by: Keith Packard <keithp@keithp.com>
This file is covered by the 2-Clause BSD license as described here: https://spdx.org/licenses/BSD-2-Clause.html Signed-off-by: Keith Packard <keithp@keithp.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Zephyr-specific re-entrant getopt family APIs with those from newlib. This allows use of the newlib and picolibc native implementations and provides a cleaner re-entrant mechanism, using a local variable to hold the getopt state instead of having a thread-local variabled tucked away in the shell context.
This will require changing all re-entrant users of getopt, switching from the Zephyr-style interfaces to the newlib-style.