drivers: can: numaker: fix m55m1x core clock #99481
Open
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: Nuvoton Numicro Numaker
zephyrbot
requested review from
alexanderwachter,
cyliangtw,
henrikbrixandersen,
martinjaeger,
ssekar15 and
str4t0m
ssekar15
requested changes
Nov 17, 2025
| clk_modidx_real = CANFD0_MODULE; | ||
| break; | ||
| case NUMAKER_CANFD1_MODULE: | ||
| clk_modidx_real = CANFD1_MODULE; |
Contributor
There was a problem hiding this comment.
missing break; ? or else add __fallthrough;
Contributor
Author
There was a problem hiding this comment.
break is missing, thanks
On M55M1 series, the clock module index is virtual to stay compatible with 32-bit only cell value in devicetree. Its real value of being 64-bit integer needs to acquire indirectly. Signed-off-by: Chun-Chieh Li <ccli8@nuvoton.com>
ccli8
force-pushed
the
nvt_m55m1_canfd_fix_clock
branch
from
2b4227c to
9efecf0
Compare
|
ssekar15
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On M55M1 series, the clock module index is virtual to stay compatible with 32-bit only cell value in devicetree. Its real value of being 64-bit integer needs to acquire via lookup into mapping table.