boards: beagle: beagleconnect_freedom: Add rev C5 support #99489
Conversation
zephyrbot
added
area: Boards/SoCs
platform: BeagleBoard
| if("${BOARD_QUALIFIERS}" MATCHES "/cc1352p7$" AND "${BOARD_REVISION}" STREQUAL "C5") | ||
| set(ACTIVE_BOARD_REVISION "C7") | ||
| message(WARNING "C5 only supports CC1352P. Using C7 instead.") | ||
| endif() | ||
|
|
||
| if("${BOARD_QUALIFIERS}" MATCHES "/cc1352p$" AND "${BOARD_REVISION}" STREQUAL "C7") | ||
| set(ACTIVE_BOARD_REVISION "C5") | ||
| message(WARNING "C7 only supports CC1352P7. Using C5 instead.") | ||
| endif() |
There was a problem hiding this comment.
this should check from the first character until either the end of the line or until a /, this code prevents users extending a board out of tree, and it should also not be changing the revision, if there is no revision provided then there can be a default set but do not override what the user has put, throw an error
There was a problem hiding this comment.
So, throwing the error breaks CI since there was no way I could find to tie an soc to a specific revision.
It was discussed here: #95065
There was a problem hiding this comment.
It uses the twister files you have, if there is no .yaml for a board target then twister will not try to use it, and you need to have the revisions in the .yaml files for the twister board name. You should probably not set a default revision anyway since it isn't valid for one of the SoCs, people should provide the correct revision
There was a problem hiding this comment.
It uses the twister files you have, if there is no .yaml for a board target then twister will not try to use it, and you need to have the revisions in the .yaml files for the twister board name. You should probably not set a default revision anyway since it isn't valid for one of the SoCs, people should provide the correct revision
Do you mean this file boards/beagle/beagleconnect_freedom/beagleconnect_freedom_cc1352p7.yaml? It can have a revisions field?
There was a problem hiding this comment.
Yes, rename and change like so: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nordic/nrf9160dk/nrf9160dk_nrf9160_0_7_0.yaml
There seem to be a decent number of C5 boards around. So add support for it while keeping C7 as the default version. The main difference between C7 and C5 is that C5 uses CC1352P instead of CC1352P7 Signed-off-by: Ayush Singh <ayush@beagleboard.org>
zephyrbot
added
area: mcumgr
area: PWM
|
4 participants
There seem to be a decent number of C5 boards around. So add support for it while keeping C7 as the default version.
The main difference between C7 and C5 is that C5 uses CC1352P instead of CC1352P7