Openthread border router fix socket close #99495
Open
+88
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
canisLupus1313,
edmont,
jukkar,
kkasperczyk-no,
maciejbaczmanski,
mariuszpos,
pdgendt,
rlubos and
ssharks
rlubos
reviewed
Nov 17, 2025
modules/openthread/platform/trel.c
Outdated
Comment on lines
55
to
60
| if (!net_mgmt(NET_REQUEST_WIFI_IFACE_STATUS, ail_iface_ptr, | ||
| &status, sizeof(status))) { | ||
| if (status.state == WIFI_STATE_COMPLETED) { | ||
| (void)trel_plat_init(ot_instance_ptr, ail_iface_ptr); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't this make a hardcoded assumption that the backbone link is Wi-Fi? Please correct me if I'm wrong, but I think this module should also work with other interface types like Ethernet?
A generic way to check if the interface is ready to transmit data would be to check net_if_is_up() - for Wi-Fi interfaces, this should only return true if the interface is connected to a Wi-Fi network.
Contributor
Author
There was a problem hiding this comment.
OTBR is planned to support both interfaces, Wi-FI or Ethernet, you are right. It would be a better idea to stick with your approach.
OpenThread interface is initialized beform Wi-Fi interface. `otPlatTrelEnable` is called by OpenThread stack when it's interface is being initialized. Given this scenario, socket operation, like `bind`, will fail. There is also no mean to get a valid pointer to backbone interface. This is why, `trel_plat_init` was declared and called when backbone interface reported connectivity. This commit handles the `ot trel disable/ot trel enable` scenario that can be initialized from CLI. `otPlatTrelEnable` will be called, but `trel_plat_init` will not be called anymore, leaving trel socket without any options set, and `net_socket_service_register` is not called anymore, to handle incoming traffic. Now, when `otPlatTrelEnable` is called, it will verify if Wi-Fi interface is connected and will call `trel_plat_init` if needed. Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Cristib05
force-pushed
the
openthread_border_router_fix_socket_close
branch
from
2523147 to
7311d26
Compare
In this commit, `net_socket_service_register` is called when a platform module that has sockets is deinitialized, and it's socket/sockets are closed. This commit also handles a case when a module tries to join a multicast group and a subscription, from another module, is already present. Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
This commit deinitializes platform modules when external network interface is brought down. It also delets the multicast routes that are added for OpenThread interface. Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Cristib05
force-pushed
the
openthread_border_router_fix_socket_close
branch
from
7311d26 to
6de7a35
Compare
|
rlubos
approved these changes
Nov 17, 2025
jukkar
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal of this PR is to handle a WI-Fi connect/disconnect or link lost and link re-established scenario.
OpenThread's platform code has been enhanced to handle those events.
Border Router application code has been updated to de-initialize platform modules and remove its multicast routes.
TREL code has been updated to accommodate user enable/disable interaction from CLI.