Define number of platform socket services using Kconfig #99499
Merged
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
canisLupus1313,
edmont,
maciejbaczmanski,
mariuszpos,
pdgendt and
rlubos
jukkar
reviewed
Nov 17, 2025
modules/openthread/Kconfig
Outdated
Comment on lines
418
to
419
| This configuration defines the maximum number of pollable mDNS sockets | ||
| to be used within platform mDNS module. |
Member
There was a problem hiding this comment.
Is this help text correct, it looks identical as the mDNS one?
Cristib05
force-pushed
the
config_platform_socket_services
branch
from
6cb3b12 to
8b34b8e
Compare
Cristib05
changed the title
rlubos
reviewed
Nov 17, 2025
modules/openthread/Kconfig
Outdated
| config OPENTHREAD_ZEPHYR_BORDER_ROUTER_MAX_UDP_SERVICES | ||
| int "The maximum number of pollable UDP sockets to be registered in platform UDP." | ||
| int "The maximum number of pollable UDP sockets to be registered in platform code." | ||
| depends on OPENTHREAD_ZEPHYR_BORDER_ROUTER |
Contributor
There was a problem hiding this comment.
This config is already behind if OPENTHREAD_ZEPHYR_BORDER_ROUTER so depends on OPENTHREAD_ZEPHYR_BORDER_ROUTER is redundant, could be removed. Same for other configs below.
Cristib05
force-pushed
the
config_platform_socket_services
branch
from
8b34b8e to
d75387a
Compare
rlubos
approved these changes
Nov 17, 2025
pdgendt
approved these changes
Nov 17, 2025
This commit adds support to define number of platform socket services using Kconfig. Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Updated platform code to make use of number of socket services defined in Kconfig. In this way, hardcoded values are avoided. Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
Cristib05
force-pushed
the
config_platform_socket_services
branch
from
d75387a to
9a4b035
Compare
jukkar
approved these changes
Nov 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide support to define number of socket services using Kconfig.