This repository was archived by the owner on Jul 11, 2019. It is now read-only.
tests: add and follow solium rules#154
Open
come-maiz wants to merge 9 commits intozeppelinos:masterfrom
Open
Conversation
come-maiz
force-pushed
the
tests/solidity-lint
branch
from
740eca1 to
91e0213
Compare
Author
|
@facuspagnuolo rules updated to 120 lines. |
Contributor
facuspagnuolo
left a comment
facuspagnuolo
left a comment
There was a problem hiding this comment.
Waiting for the new approach we discussed offline to tackle linter rules
.soliumrc.json
Outdated
| "quotes": ["error", "double"], | ||
| "no-empty-blocks": "off", | ||
| "indentation": ["error", 2], | ||
| "max-len": ["error", 79], |
come-maiz
force-pushed
the
tests/solidity-lint
branch
from
2b6bd98 to
2daf329
Compare
Author
|
@facuspagnuolo this is ready updating the style rules as warnings. |
Pull Request Test Coverage Report for Build 614
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought to you with 🤓 by the #static task force.
Remember that if you have
$opinions, you should report an issue on https://github.com/ZeppelinSolutions/code-style where we will discuss about it and then update the rules accordingly, if required.