Open
Conversation
…or base deploy mission.
…nfig, include src and test directories. Added some start tests
…ock fixes to satisfy new tests.
Whytecrowe
reviewed
Oct 9, 2024
|
|
||
| // this.timeout() doesn't work for arrow functions. | ||
| describe("Base deploy mission", function () { | ||
| this.timeout(5000); |
Collaborator
Author
There was a problem hiding this comment.
From time to time, flow falls by timeout of 2000ms. When I increased this, it helps. I know, its not for our soft, It's only for my machine. But I just wanted to keep it while the PR has WIP status. Or should I remove it before each push?
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
test/cases/DBVersioner.test.ts
Outdated
| await mongoAdapter.initialize(dbVersion); | ||
| }); | ||
|
|
||
| it("Should return existing temp version when calls configureVersioning()", async () => { |
Contributor
There was a problem hiding this comment.
not sure what this is testing
Collaborator
Author
There was a problem hiding this comment.
It shows that DB Versioner can find correct final version if it exists
Tell me if I'm wrong
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
Whytecrowe
reviewed
Oct 9, 2024
…st helper to check the contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.