Conversation
…token/NFT display and navigation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
domw30
deleted the
feat/add-transaction-detail-view-with-improved-token-nft-display-and-navigation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
We're adding a transaction detail view that opens when clicking transactions, updating navigation to use hash-action URLs for unique identification, displaying proper token names/symbols/icons, showing NFT placeholders for NFTs, making token IDs copyable and truncated, and simplifying transaction type categorization to use the API type field directly.
Why are we making this change?
To improve UX by showing detailed transaction information in-app instead of opening external explorers, and to properly support and display the various transaction types (ERC-20 tokens, NFTs, mints, burns) with accurate token information from the API response.
How do I test this?
Key decisions and Risk Assessment:
Things to consider: