Extend tool for listing all project members (including inheritance) #307
Conversation
Modify URL construction for listing project members based on inheritance option.
There was a problem hiding this comment.
Pull request overview
This PR extends the listProjectMembers function to support including inherited members from parent groups. This addresses issue #306 by adding an optional include_inheritance parameter.
Changes:
- Added
include_inheritanceboolean parameter to theListProjectMembersSchemain schemas.ts - Modified
listProjectMembersfunction in index.ts to conditionally use/members/allendpoint when inheritance is requested
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| schemas.ts | Adds include_inheritance optional boolean parameter to the ListProjectMembersSchema |
| index.ts | Implements conditional URL construction to use /members/all endpoint when include_inheritance is true |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (options.include_inheritance) { | ||
| const url = new URL( | ||
| `${getEffectiveApiUrl()}/projects/${encodeURIComponent(effectiveProjectId)}/members/all` | ||
| ); | ||
| } | ||
| else | ||
| { | ||
| const url = new URL( | ||
| `${getEffectiveApiUrl()}/projects/${encodeURIComponent(effectiveProjectId)}/members` | ||
| ); | ||
| } |
There was a problem hiding this comment.
The url variable is declared within the if/else block scopes, making it inaccessible to the code at line 4652 and beyond that tries to use it. Declare url before the if statement and assign it within each branch without the const keyword.
| else | ||
| { |
There was a problem hiding this comment.
The opening brace should be on the same line as else to maintain consistency with the project's formatting style (as seen throughout the rest of the codebase).
|
Not needed anymore as solved with #316 |
2 participants
Added proposed changes as mentioned in #306.