feat: add sendUserOperations #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SahilVasava
reviewed
Nov 28, 2024
| import { parseAccount } from "viem/accounts" | ||
| import { getAction } from "viem/utils" | ||
|
|
||
| export type ClientWithChainId< |
Collaborator
There was a problem hiding this comment.
Why do we need ClientWithChainId? Couldn't we just get it from original client like this client.chain.id ?
SahilVasava
reviewed
Nov 28, 2024
| import { parseAccount } from "viem/accounts" | ||
| import { getAction } from "viem/utils" | ||
|
|
||
| export type ClientWithChainId< |
SahilVasava
requested changes
Nov 28, 2024
Collaborator
SahilVasava
left a comment
SahilVasava
left a comment
There was a problem hiding this comment.
- The sendUserOperations could be simplified further. But should be fine for now.
- Since it doesn't work with Alchemy, we should investigate further. Although we can release this version to unblock the customer meanwhile.
multiChainEcdsatests are passing with Pimlico so all good- We should test
multiChainWebAuthnas well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.