feat: add support to enable mTLS #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds a variable: `enable_tls` on both client and server to enable mTLS config * adds a variable: `tls_certificates` that takes base64 encoded certificate files for `ca_file`, `cert_file`, `key_file` * adds variables: `tls_http_enable` and `tls_rpc_enable` to manually enable TLS for HTTP (default: `false`) and RPC (default: `true`). The default values enable intra-cluster mTLS while allowing end user to access Nomad using CLI without requiring the TLS certificates Right now there's no way to verify if the variables are actually set, since terraform does not support validation based on other variable values. Signed-off-by: Chinmay D. Pai <chinmay.pai@zerodha.com>
this ensures that if tls over http is disabled, then the end users are not required to produce TLS certificates for accessing nomad cluster using CLI Signed-off-by: Chinmay D. Pai <chinmay.pai@zerodha.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_tlson both client and server to enable mTLS configtls_certificatesthat takes base64 encoded certificate files forca_file,cert_file,key_filetls_http_enableandtls_rpc_enableto manually enable TLS for HTTP (default:false) and RPC (default:true). The default values enable intra-cluster mTLS while allowing end user to access Nomad using CLI without requiring the TLS certificatesRight now there's no way to verify if the variables are actually set, since terraform does not support validation based on other variable values.