[mldsa] Add randomness parameter for signing.#205
Merged
jadephilipoom merged 1 commit intomasterfrom Mar 2, 2026
Merged
Conversation
This allows a little more flexibility with how the random value is sourced; it allows tests to provide a predetermined random value, while runtime binaries could still populate this with 0 or RND. Signed-off-by: Jade Philipoom <jadep@zerorisc.com>
pqcfox
approved these changes
Mar 2, 2026
Contributor
pqcfox
left a comment
pqcfox
left a comment
There was a problem hiding this comment.
Looks great, thanks so much for tag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a little more flexibility with how the random value is sourced; it allows tests to provide a predetermined random value, while runtime binaries could still populate this with 0 or RND.
For now the behavior is completely unchanged; the testgen infrastructure always populates with 0. For context, this tweak was necessary to use a not-yet-merged benchmarking technique for ML-DSA signing that requires variable randomness. I'd merge it along with that technique, but I built some code-size improvements on top of this and those are ready to merge now, so it would be nice to get this in a bit early.