Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
portfolio | 46ee7eb | Dec 11 2025, 05:50 AM |
|
@codex review |
Summary of ChangesHello @zerozero-0-0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature to collect and store AtCoder submission data, likely as a foundational step for displaying an activity heatmap. It also includes an update to the GitHub API request headers used within the project's worker, ensuring proper interaction with the GitHub API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub script to fetch AtCoder submission data and store it in Cloudflare KV, and also updates GitHub API headers in the Cloudflare worker. The changes to the worker are good, aligning with current GitHub API best practices.
My review of the new script has identified a few areas for improvement to enhance its robustness and correctness:
- Environment Variable Validation: The script should validate all required environment variables at startup.
- Date Calculation: There's an issue with how the 'from' timestamp is calculated, which could lead to incomplete data fetching.
- Error Handling: The script incorrectly treats a valid empty submission history as an error.
- Code Style: A suggestion is provided to make part of the code more concise.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds support for tracking AtCoder problem submissions by introducing a new data collection script and updating the GitHub API headers to use the current API version specification.
- Adds a new script to fetch and store daily AtCoder submission counts in Cloudflare KV
- Updates GitHub API headers to use the modern format with explicit API version
- Sets up infrastructure for displaying AtCoder problem-solving activity (heatmap functionality)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
worker/index.ts |
Updates GitHub API headers to use modern application/vnd.github+json format and adds explicit API version 2022-11-28 |
.github/scripts/update-atcoder-problems-data.mjs |
Adds new script to fetch yesterday's AtCoder AC submissions and store the count in Cloudflare KV for heatmap visualization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const CACHE_KEY_PREFIX = "atcoder-problems-submission"; | ||
| const STALE_THRESHOLD_MS = 1000 * 60 * 60 * 24 * 14; // 14 days |
There was a problem hiding this comment.
The new AtCoder Problems cache reader builds its cache key with the atcoder-problems-submission prefix (CACHE_KEY_PREFIX), but both the init/update scripts write the heatmap payload to atcoder-problems-data:${username} (.github/scripts/init-atcoder-problems-data.mjs lines 1-9). Because the prefixes differ, the fetcher will never find the populated KV value and will always return {ok: false, rating: null}, so the new heatmap data cannot be served even after initialization.
Useful? React with 👍 / 👎.
1 participant
No description provided.