feat: Uniswap v3 pools by fadeev · Pull Request #130 · zeta-chain/localnet

fadeev · 2025-03-21T06:36:44Z

Deploy Uniswap v3
Added liquidity
Added a bunch of checks to verify that liquidity indeed has been added. We'll probably want to not output that to the console. Maybe we should add a --verbose flag.

Position data: {
  tokenId: '1',
  position: {
    nonce: '0',
    operator: '0x0000000000000000000000000000000000000000',
    token0: '0x2ca7d64A7EFE2D62A725E2B35Cf7230D6677FfEe',
    token1: '0x5FbDB2315678afecb367f032d93F642f64180aa3',
    fee: '3000',
    tickLower: '-887220',
    tickUpper: '887220',
    liquidity: '100000000000000000005',
    feeGrowthInside0LastX128: '0',
    feeGrowthInside1LastX128: '0',
    tokensOwed0: '0',
    tokensOwed1: '0'
  }
}
Position data: {
  tokenId: '2',
  position: {
    nonce: '0',
    operator: '0x0000000000000000000000000000000000000000',
    token0: '0x5FbDB2315678afecb367f032d93F642f64180aa3',
    token1: '0x91d18e54DAf4F677cB28167158d6dd21F6aB3921',
    fee: '3000',
    tickLower: '-887220',
    tickUpper: '887220',
    liquidity: '100000000000000000005',
    feeGrowthInside0LastX128: '0',
    feeGrowthInside1LastX128: '0',
    tokensOwed0: '0',
    tokensOwed1: '0'
  }
}

Can be tested with:

Swap: use Uniswap v3 pools example-contracts#251

fadeev · 2025-03-26T15:19:03Z

@lumtis @skosito please, review.

fadeev · 2025-04-09T13:20:22Z

@lumtis @skosito @zeta-chain/devex please, review.

skosito · 2025-04-15T13:58:53Z

packages/localnet/src/tokens/createSolanaToken.ts

+    tssKeypair,
+    tssKeypair.publicKey,
+    null,
+    9


same question for createEVMToken, just to double check, there is no need to customize decimals?

SPL decimals: c8fa7df

ERC-20 decimals: #150

skosito · 2025-04-15T14:00:35Z

packages/localnet/src/tokens/createToken.ts

+import { uniswapV2AddLiquidity } from "./uniswapV2";
+import { uniswapV3AddLiquidity } from "./uniswapV3";
+
+export const createToken = async (


up to you, but i think it would be helpful to add some doc comments for functions, maybe just for exported since there is a lot of going on

skosito · 2025-04-15T14:01:47Z

packages/localnet/src/tokens/createToken.ts

+  const suiNotSupported = chainID === NetworkID.Sui && !contracts.suiContracts;
+
+  if (solanaNotSupported || suiNotSupported) {
+    return;


i see below other networks token are created, why do we return if solana or sui are not supported?

This function returns if we're creating a Solana token and Solana has not been initialized. Same for Sui.

skosito · 2025-04-15T14:02:59Z

packages/localnet/src/tokens/createToken.ts

+
+  let asset;
+
+  if (isGasToken) {


maybe its more clear to use switch for chain id part

skosito · 2025-04-15T14:03:39Z

packages/localnet/src/tokens/createToken.ts

+
+  foreignCoins.push({
+    asset,
+    coin_type: isGasToken ? "Gas" : chainID === NetworkID.Sui ? "SUI" : "ERC20",


here for solana would be SPL?

skosito · 2025-04-15T14:06:38Z

packages/localnet/src/tokens/uniswapV3.ts

+  wzetaAmount: any,
+  uniswapV3Factory: any,
+  uniswapV3PositionManager: any,
+  verbose: boolean = false


is this flag used around localnet?

It's not used yet, but we'll need to add support for this.

skosito · 2025-04-15T14:08:19Z

packages/localnet/src/tokens/uniswapV3.ts

+    console.error("Error adding liquidity to Uniswap V3:", error);
+    if (error.message?.includes("LOK")) {
+      console.error(
+        "Pool initialization error - pool may already be initialized"


nit but maybe in case pool is created we still allow liq to be added?

This is inside catch, so we're not throwing an error if a pool has been initialized, we're just explaining why adding liquidity may have failed.

fadeev added 2 commits March 21, 2025 09:18

test

e6add83

refactor

144d0f8

fadeev linked an issue Mar 21, 2025 that may be closed by this pull request

Deploy Uniswap v3 pools with liquidity on ZetaChain #131

Closed

This comment was marked as resolved.

Sign in to view

fadeev added 7 commits March 21, 2025 09:41

lint

877c33f

refactor

3e8fbdf

output v3 addresses

a8605f3

Merge branch 'main' into uni-v3-test

85e16f9

refactor

51e0e53

lint

0a4a3b6

refactor

4ec780d

fadeev marked this pull request as ready for review March 26, 2025 10:05

fadeev requested review from a team, lumtis and skosito as code owners March 26, 2025 10:05

skosito approved these changes Apr 15, 2025

View reviewed changes

custom decimals for SPL tokens

c8fa7df

fadeev requested a review from swift1337 as a code owner April 16, 2025 08:52

fadeev added 3 commits April 16, 2025 11:59

docs

afc00a0

use switch chain ID

0a7611d

use SPL for Solana

9d15e1c

fadeev requested a review from skosito April 16, 2025 09:13

Merge branch 'main' into uni-v3-test

2eecea4

fadeev merged commit 1703815 into main Apr 16, 2025
4 checks passed

fadeev added the feat label Apr 17, 2025

Conversation

fadeev commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

fadeev commented Mar 26, 2025

Uh oh!

fadeev commented Apr 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadeev Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fadeev commented Mar 21, 2025 •

edited

Loading

fadeev Apr 16, 2025 •

edited

Loading