Skip to content

Conversation

@JPTomorrow
Copy link

UI improvements as per issue #2.

I have added a countdown after the user selects their input. It displays "ROCK", followed by "PAPER", followed by "SCISSORS", followed by "SHOOT!" in 500 millisecond interval before showing the result.

This mimics the real life tradition in RPS of shouting out "ROCK, PAPER, SCISSORS, SHOOT!" before both players throw out their hand with the selection they have made. It adds a small feeling of suspense and engagement before the result that I feel is missing.

I have also taken the opportunity to assign a fixed width to the result text so that surrounding elements do not reposition themselves as the result text changes.

Added vscode ignores to ,gitignore as well.

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for rock-paper-scissors-game0302 ready!

Name Link
🔨 Latest commit b4dace0
🔍 Latest deploy log https://app.netlify.com/sites/rock-paper-scissors-game0302/deploys/638f92c8ce612100092e311d
😎 Deploy Preview https://deploy-preview-8--rock-paper-scissors-game0302.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JPTomorrow JPTomorrow closed this by deleting the head repository Dec 6, 2022
@JPTomorrow JPTomorrow reopened this Dec 6, 2022
@zetabug
Copy link
Owner

zetabug commented Aug 15, 2023

@JPTomorrow Great work.
Though I have already merged a PR that added shake animation to the project, so the countdown has already been added, but it doesn't display ROCK, PAPER, SCISSORS before countdown. It would look cool if it displays the words before countdown.

I want you to submit a new PR working your way around the latest features added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants