Skip to content

Conversation

@manuelmorales
Copy link

Net::HTTP.post_form on Ruby 1.9.3 won't detect the HTTPS protocol and enable SSL. This fix checks the scheme and enables it when necessary.

@zevarito
Copy link
Owner

Hi @manuelmorales, tests are failing, can you check it out before merge?

Thanks.

@manuelmorales
Copy link
Author

Bundle exec rake run green for me. What version of ruby do you use?
On 11 Feb 2014 17:09, "Alvaro Gil" notifications@github.com wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing,
can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHubhttps://github.com//pull/133#issuecomment-34776353
.

@zevarito
Copy link
Owner

Is not me is Travis :)

On Tue, Feb 11, 2014 at 7:42 PM, Manuel Morales notifications@github.comwrote:

Bundle exec rake run green for me. What version of ruby do you use?
On 11 Feb 2014 17:09, "Alvaro Gil" notifications@github.com wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing,
can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHub<
https://github.com/zevarito/mixpanel/pull/133#issuecomment-34776353>

.


Reply to this email directly or view it on GitHubhttps://github.com//pull/133#issuecomment-34811218
.

Alvaro

@manuelmorales
Copy link
Author

Ups, I didn't notice that I broke the Ruby 1.9.2 build. I just fixed it. Now the build is still broken, but that's because of the already existing problem with JRuby in 1.8 mode.

@zevarito
Copy link
Owner

Hi @manuelmorales did you know about this project? https://github.com/mixpanel/mixpanel-ruby

It is the official Mixpanel Ruby Gem, I've stopped this Gem development in favor of that one.

Please take a look an tell me if you want to still use this Gem and I'll merge your PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants