refactor: extract config dataclasses and defer heavy imoprts#90
Closed
MaleicAcid wants to merge 1 commit intozh-plus:masterfrom
Closed
refactor: extract config dataclasses and defer heavy imoprts#90MaleicAcid wants to merge 1 commit intozh-plus:masterfrom
MaleicAcid wants to merge 1 commit intozh-plus:masterfrom
Conversation
pulumi
bot
force-pushed
the
extract-config-lazy-imports
branch
from
0e17de3 to
da12c6e
Compare
…orts to method level
pulumi
bot
force-pushed
the
extract-config-lazy-imports
branch
from
da12c6e to
ed17c3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #89.
Changes
openlrc/config.py(new):TranscriptionConfigandTranslationConfigextracted here, depends only on stdlib +ModelConfig.openlrc/__init__.py: re-exports fromconfig.pyinstead ofopenlrc.py. Public API unchanged.openlrc/openlrc.py: removed dataclass definitions; deferredPreprocessor,Transcriber,LLMTranslator,TranslateInfoto method-level imports; movedSegmentintoTYPE_CHECKINGblock.openlrc/preprocess.py: deferredtorchanddf.enhanceintonoise_suppression().tests/test_preprocess.py:@patchtargets changed fromopenlrc.preprocess.enhancetodf.enhance.enhance(patch at source module).