Merged
Conversation
Owner
|
Thanks for working on this. Moving the config dataclasses out of I don’t think it fully resolves #89 yet, because there are still some eager imports in the package path, but this is a solid incremental step and the direction looks right. I’m going to merge this PR now, and I’ll follow up with another PR to continue the import-cleanup work and fully address the remaining parts of #89. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #89 .
Changes
openlrc/config.py(new): extractTranscriptionConfigandTranslationConfigfromopenlrc.py. Only depends on stdlib +ModelConfig.openlrc/__init__.py: re-export fromconfig.pyinstead ofopenlrc.py. Public API unchanged.openlrc/openlrc.py: remove dataclass definitions; deferPreprocessor,Transcriber,LLMTranslator,TranslateInfoto method-level imports; moveSegmentintoTYPE_CHECKINGblock.openlrc/preprocess.py: defertorchanddf.enhanceintonoise_suppression().tests/test_preprocess.py: usesys.modulesfake module +patch.object()instead of@patch("df.enhance.xxx")string paths to fix Python 3.10 compatibility (3.10'smock.patchhas a caching bug when module name and function name collide).