Thread safety#37
Merged
zhangbo8418 merged 9 commits intozhangbo8418:Testfrom Nov 18, 2025
Merged
Conversation
Implemented operation queue system to handle group, guild, arena, and battleground operations in the world thread instead of map threads. This fixes race conditions and crashes when multiple bots interact with groups simultaneously. Changes: - Added PlayerbotOperation base class and world thread processor - Group operations: invite, remove, convert to raid, set leader - Arena formation: complex multi-step workflow in single operation - Guild operations: changed to use packet queueing - Bot logout: queue group cleanup to avoid races All thread-unsafe operations now execute safely in the world thread via the operation queue processed in WorldScript::OnUpdate.
- Add missing #include <memory> to PlayerbotOperation.h for std::unique_ptr - Fix buffer overflow warning in PlayerbotAIConfig.cpp GetTimestampStr()
This reverts commit 64da37dd3775385c38c884b7850a5d8af4ab8137.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.