[InsertSync] scalar autosync + addptr alias-through (scalar-only scope)#206
Open
TaoTao-real wants to merge 4 commits intozhangstevenunity:mainfrom
Open
[InsertSync] scalar autosync + addptr alias-through (scalar-only scope)#206TaoTao-real wants to merge 4 commits intozhangstevenunity:mainfrom
TaoTao-real wants to merge 4 commits intozhangstevenunity:mainfrom
Conversation
Contributor
Author
|
Added commit A3 remote validation (CI script flow):
Result:
Extra note: when additionally running |
269dedb to
40cee3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pto.load_scalar/pto.store_scalarparticipate in InsertSync asPIPE_Sopspto.addptralias-through in InsertSync translator, including constant-offset byte folding and conservative handling for dynamic offsetsPIPE_S -> PIPE_Slocal sync insertionset_flag/wait_flagsync (no forcedPIPE_ALLfallback)test_inject_sync_scalar_cross_pipe.pytest_inject_sync_scalar_intra_pipe_barrier.pyScope
This PR is intentionally scalar-sync only.
Layout-inference changes (e.g. rowmin/rowsum/rowmax related fixes) are explicitly excluded from this PR.
Motivation
InsertSync previously could miss synchronization around scalar load/store paths and
addptralias chains, which risks under-synchronization in scalar-memory-involved dependencies.Design
LoadScalarOp/StoreScalarOpOpPipeInterfacePIPE_SingetPipe()PIPE_Sis skipped (in-order scalar pipeline)set_flag/wait_flagpto.addptrto alias chain updatesaddptroffsets in byte-range analysisaddptroffsets use conservative alias modeling (prefer over-sync to under-sync)Testing
Local regression:
Result: pass (A5-only sample skipped as expected).
A3 remote board validation (latest, commit
6c8c44e):101.245.68.6(DEVICE_ID=10,SOC_VERSION=Ascend910)test/npu_validation/scripts/run_remote_npu_validation.shOK=19, FAIL=0, SKIP=1test_inject_sync_scalar_cross_pipe:OKtest_inject_sync_scalar_intra_pipe_barrier:OKRisk / Rollback
PIPE_Sremains skipped; cross-pipe behavior follows existing set/wait model and has local + remote regression coverage