Add standalone per-case golden scripts for 4.5-4.9 samples#251
Add standalone per-case golden scripts for 4.5-4.9 samples#251HecreReed wants to merge 8 commits intozhangstevenunity:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9643c7cee3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
test/samples/Colsum/colsum_golden.py
Outdated
| out_m[0, :] = reduced + out_m[0, :] | ||
| out = out_m.reshape(-1) | ||
| elif out.size == COLS: | ||
| out = reduced + out |
There was a problem hiding this comment.
Compute pure column reduction in colsum golden
The custom colsum oracle currently adds the reduced sum to an initialized destination buffer (reduced + out), but pto.tcolsum semantics are dst[0,j] = sum_i src[i,j] with tmp only as workspace (see docs/PTO_IR_manual.md), so this produces an incorrect golden for this case and causes deterministic compare failures when validating colsum.
Useful? React with 👍 / 👎.
Summary
*_golden.py/*_compare.pyundertest/samples/*for the PTO manual 4.5–4.9 casesgenerate_testcase.pyprefer sample-local custom assets and emitvalidation_meta.envValidation
python3 -m py_compile test/npu_validation/scripts/generate_testcase.py test/samples/*/*_golden.py test/samples/*/*_compare.pygolden.py+compare.pyforVectorAddition/vectorAdditionandCmp/cmpgenerate_testcase.pywith custom asset pickup for representative cases in local temp dirstest/npu_validation/scripts/run_remote_npu_validation.shusing handcrafted payload:shls,vectorAddition,sel,expandscolsum,cmpNotes
colsumandcmpstill show golden diff in the remote subset run and need follow-up