Fixed Playing and Pausing when in mode internet radio#11
Open
SpeedyGoneZales wants to merge 1 commit intozhelev:masterfrom
Open
Fixed Playing and Pausing when in mode internet radio#11SpeedyGoneZales wants to merge 1 commit intozhelev:masterfrom
SpeedyGoneZales wants to merge 1 commit intozhelev:masterfrom
Conversation
Collaborator
|
pausing and stopping is not the same. Please remove the override in the pause function and add a dedicated stop function instead. please don't change the forward/rewind functions. They function as desired: they raise an error when the radio is in an invalid mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in mode Internet Radio, playing and stopping a stream is achieved running
http://<IP>/fsapi/SET/netRemote.play.control?pin=1234&value=0, whereas in other modes value is 1 for Play and 2 for Pause.This pull request checks which mode the radio is in, and send 0 (aka STOP) when in Internet radio mode.