decode: Don't write past the end of the input buffer #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing the test program to allocate exactly the correct amount of space for the decode buffer, we can see (using valgrind) that the previous algorithm would (depending on the length) write one byte past the end of the buffer. Preserve the extra bits in a local variable to be added into the next byte, rather than storing them in the next byte itself.
Owner
|
What do you mean "exactly the correct amount of space" ? The encode and decode function should work any length of input. not exactly length of input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the test program to allocate exactly the correct
amount of space for the decode buffer, we can see (using valgrind)
that the previous algorithm would (depending on the length) write
one byte past the end of the buffer.
Preserve the extra bits in a local variable to be added into the
next byte, rather than storing them in the next byte itself.