Skip to content

fix:处理build clean脚本在win平台兼容性#241

Merged
lc-cn merged 2 commits intozhinjs:mainfrom
abandon-jw3:main
Feb 13, 2026
Merged

fix:处理build clean脚本在win平台兼容性#241
lc-cn merged 2 commits intozhinjs:mainfrom
abandon-jw3:main

Conversation

@abandon-jw3
Copy link

@abandon-jw3 abandon-jw3 commented Feb 13, 2026

1、使用兼容性写法修改build脚本
2、使用rimraf处理跨平台rm命令
3、使用cross-env处理跨平台环境变量


Summary by cubic

Fix Windows compatibility for build/clean/test scripts. Replaced Unix-only commands, fixed shell quoting, and removed the @zhin.js/types types reference from the root tsconfig.

  • Bug Fixes

    • Replaced rm -rf with rimraf across packages and plugins; added rimraf to root devDependencies and to plugin/workspace templates.
    • Used cross-env for NODE_ENV/WASM and vitest scripts in packages/satori; added cross-env devDependency.
    • Quoted pnpm --filter patterns in the root build script for Windows shells; set tsconfig types to "node" in create-zhin.
    • Removed @zhin.js/types from the root tsconfig types; set types to [].
  • Migration

    • Run pnpm install after pulling to install new dev dependencies.

Written for commit 6abec3e. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 33 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="plugins/utils/music/package.json">

<violation number="1" location="plugins/utils/music/package.json:21">
P1: rimraf is used in the clean script but not declared in devDependencies. In this pnpm workspace, each package must explicitly declare its dependencies for the binary to be available.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@lc-cn lc-cn merged commit beab00b into zhinjs:main Feb 13, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants