B3.1.4

[ziembor]

No description provided.

[claude]

PR Review: B3.1.4

Overall this PR is a reasonable simplification — consolidating docs and streamlining the build script reduces maintenance surface. A few things worth addressing before merging:

---

build-all.ps1 — Missing error handling after go build

Critical issue: After removing the try/catch block, the script no longer checks $LASTEXITCODE after go build. If the build fails, the script will still print a success message:

# Current code — no exit code check
if ($Verbose) {
    go build -v -ldflags="-s -w" -o $outputFile ./cmd/gomailtest
} else {
    go build -ldflags="-s -w" -o $outputFile ./cmd/gomailtest
}

Write-ColorOutput "  Built bin/gomailtest.exe — version $version" "Green"  # always runs!

Suggested fix:

if ($Verbose) {
    go build -v -ldflags="-s -w" -o $outputFile ./cmd/gomailtest
} else {
    go build -ldflags="-s -w" -o $outputFile ./cmd/gomailtest
}

if ($LASTEXITCODE -ne 0) {
    Write-ColorOutput "  ✗ Build failed with exit code $LASTEXITCODE" "Red"
    exit 1
}

Write-ColorOutput "  Built bin/gomailtest.exe — version $version" "Green"

---

build-all.ps1 — Version extraction gives poor errors on failure

The new one-liner will throw an opaque NullReferenceException if version.go doesn't exist or the pattern doesn't match:

$version = (Select-String -Path ... -Pattern ...).Matches[0].Groups[1].Value

The old explicit error-checking approach was more user-friendly. If you want to keep it concise, at minimum add a null guard:

$match = Select-String -Path (Join-Path $PSScriptRoot "internal/common/version/version.go") -Pattern 'Version = "([^"]+)"'
if (-not $match) { Write-ColorOutput "ERROR: Could not extract version from version.go" "Red"; exit 1 }
$version = $match.Matches[0].Groups[1].Value

---

version.go — Version jump from 3.1.1 to 3.1.4

The version jumps three patch versions (3.1.1 → 3.1.4). If 3.1.2 and 3.1.3 were used internally or in prior branches, that's fine — but worth confirming this is intentional and that the changelog entries exist for each skipped version if the project tracks those.

---

.github/workflows/build.yml — fail-fast: false

Good addition. This ensures a macOS or Linux build failure doesn't cancel the Windows build mid-run, giving more complete CI signal.

---

Documentation consolidation

The TOOLS.md consolidation is clean and the workflow changes are consistent across both Windows and Linux/macOS ZIP steps. The release notes wording improvement (** *_TOOL_README.md** → **TOOLS.md**) also fixes a pre-existing markdown formatting quirk.

---

Summary

Item	Severity	Status
No error check after go build	High	Needs fix
Opaque error on version extraction failure	Low	Suggested improvement
Version jump 3.1.1 → 3.1.4	Low	Verify intentional
fail-fast: false	—	Good change
Docs consolidation	—	Good change

The build error check is the main blocker — without it, CI could report a green build when compilation actually failed.