Fix getUserInfo on MacOS #24934
Open
Fix getUserInfo on MacOS #24934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxpv
force-pushed
the
user
branch
2 times, most recently
from
99a7b6a to
b7e8390
Compare
|
Fixed test + rebased. |
|
oh, I see.
|
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
|
@alexrp could you pls take a look? Anything else I could do to get it going? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #23658
In current implementation,
posixGetUserInfoparses/etc/passwd, which is insufficient in certain environments where accounts might be stored elsewhere (LDAP, Directory Services on macOS, etc.)This PR uses
getpwnamwhen linking against libc (and fallbacks to the original implementation), which offers more advanced (OS specific) capabilities under the hood.